Bug 59608 - Change TEXMAP_OPENGL_ES2 to TEXMAP_OPENGL_ES_2
Summary: Change TEXMAP_OPENGL_ES2 to TEXMAP_OPENGL_ES_2
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: Qt
Depends on:
Blocks: 47068
  Show dependency tree / graph
 
Reported: 2011-04-27 08:31 PDT by Young Han Lee
Modified: 2011-05-01 10:25 PDT (History)
6 users (show)

See Also:

Attachments
Patch (1.61 KB, patch)
2011-04-27 08:33 PDT, Young Han Lee 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Young Han Lee 2011-04-27 08:31:26 PDT 
Change TEXMAP_OPENGL_ES2 to TEXMAP_OPENGL_ES_2
Comment 1 Young Han Lee 2011-04-27 08:33:29 PDT 
Created attachment 91288 [details]
Patch
Comment 2 Young Han Lee 2011-04-27 08:36:09 PDT 
TEXMAP_OPENGL_ES2 is a wrong name. TEXMAP_OPENGL_ES_2 is already defined in TextureMapper.h
Comment 3 Young Han Lee 2011-05-01 09:14:27 PDT 
Is there anybody who can review this patch?
This bug is very obvious and causes compile error in OPENGLES environment.

>:~/Works/WebKit/Source/WebCore/platform$ grep -R TEXMAP_OPENGL_ES *
graphics/opengl/TextureMapperGL.cpp:#if defined(TEXMAP_OPENGL_ES_2)
graphics/opengl/TextureMapperGL.cpp:#ifndef TEXMAP_OPENGL_ES2
graphics/opengl/TextureMapperGL.cpp:#ifndef TEXMAP_OPENGL_ES2
graphics/texmap/TextureMapper.h:    #if defined(QT_OPENGL_ES_2) && !defined(TEXMAP_OPENGL_ES_2)
graphics/texmap/TextureMapper.h:        #define TEXMAP_OPENGL_ES_2
Comment 4 Eric Seidel (no email) 2011-05-01 09:40:32 PDT 
Comment on attachment 91288 [details]
Patch

Looks reasonable.
Comment 5 WebKit Commit Bot 2011-05-01 10:25:43 PDT 
Comment on attachment 91288 [details]
Patch

Clearing flags on attachment: 91288

Committed r85417: <http://trac.webkit.org/changeset/85417>
Comment 6 WebKit Commit Bot 2011-05-01 10:25:48 PDT 
All reviewed patches have been landed.  Closing bug.