RESOLVED FIXED 59603
[GTK] WKView should be a GtkWidget 
https://bugs.webkit.org/show_bug.cgi?id=59603
Summary [GTK] WKView should be a GtkWidget
Carlos Garcia Campos
Reported 2011-04-27 05:10:06 PDT
This way, the use of WebKitWebBase will be transparent for the C API and we can get rid of WKViewGetWindow() which is very confusing because it doesn't return a window, but a GtkWidget that is indeed the view.
Attachments
Patch (9.12 KB, patch)
2011-04-27 05:30 PDT, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
New patch (4.49 KB, patch)
2011-04-28 00:33 PDT, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2011-04-27 05:30:53 PDT
Created attachment 91274 [details] Patch
Carlos Garcia Campos
Comment 2 2011-04-28 00:33:26 PDT
Created attachment 91440 [details] New patch As martin poined out, we don't need a new class inheriting from WebKitWebViewBase, we can simply map WKViewRef to WebKitWebViewBase. So this patch leaves WebKitWebViewBase as a non-abstract class and makes WKViewCreate return the widget instead of the page client so that WKView can be used as a widget.
Carlos Garcia Campos
Comment 3 2011-04-28 09:29:09 PDT
Committed r85192: <http://trac.webkit.org/changeset/85192>
Note You need to log in before you can comment on or make changes to this bug.