Bug 59603 - [GTK] WKView should be a GtkWidget
Summary: [GTK] WKView should be a GtkWidget
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
Keywords: Gtk
Depends on: 59594
Blocks: 57944
  Show dependency treegraph
Reported: 2011-04-27 05:10 PDT by Carlos Garcia Campos
Modified: 2011-04-28 09:29 PDT (History)
3 users (show)

See Also:

Patch (9.12 KB, patch)
2011-04-27 05:30 PDT, Carlos Garcia Campos
no flags Details | Formatted Diff | Diff
New patch (4.49 KB, patch)
2011-04-28 00:33 PDT, Carlos Garcia Campos
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2011-04-27 05:10:06 PDT
This way, the use of WebKitWebBase will be transparent for the C API and we can get rid of WKViewGetWindow() which is very confusing because it doesn't return a window, but a GtkWidget that is indeed the view.
Comment 1 Carlos Garcia Campos 2011-04-27 05:30:53 PDT
Created attachment 91274 [details]
Comment 2 Carlos Garcia Campos 2011-04-28 00:33:26 PDT
Created attachment 91440 [details]
New patch

As martin poined out, we don't need a new class inheriting from WebKitWebViewBase, we can simply map WKViewRef to WebKitWebViewBase. So this patch leaves WebKitWebViewBase as a non-abstract class and makes WKViewCreate return the widget instead of the page client so that WKView can be used as a widget.
Comment 3 Carlos Garcia Campos 2011-04-28 09:29:09 PDT
Committed r85192: <http://trac.webkit.org/changeset/85192>