RESOLVED INVALID59601
[GTK] Do not initialize wep application database if it was disabled at configure time. 
https://bugs.webkit.org/show_bug.cgi?id=59601
Summary [GTK] Do not initialize wep application database if it was disabled at config...
Alexandre Mazari
Reported 2011-04-27 04:55:42 PDT
[GTK] Do not initialize wep application database if it was disabled at configure time.
Attachments
Patch (1.42 KB, patch)
2011-04-27 04:57 PDT, Alexandre Mazari 		mrobinson: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexandre Mazari
Comment 1 2011-04-27 04:57:07 PDT
Created attachment 91270 [details] Patch
Martin Robinson
Comment 2 2011-04-27 13:36:41 PDT
Comment on attachment 91270 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=91270&action=review Very nice. One small suggestion below. > Source/WebKit/gtk/webkit/webkitglobals.cpp:271 > gchar* databaseDirectory = g_build_filename(g_get_user_data_dir(), "webkit", "databases", NULL); > webkit_set_web_database_directory_path(databaseDirectory); > WebCore::cacheStorage().setCacheDirectory(databaseDirectory); > > g_free(databaseDirectory); Please switch to using GOwnPtr for databaseDirectory: GOwnPtr<gchar> databaseDirectory = g_build_filename(g_get_user_data_dir(), "webkit", "databases", NULL); webkit_set_web_database_directory_path(databaseDirectory.get()); WebCore::cacheStorage().setCacheDirectory(databaseDirectory.get());
Philippe Normand
Comment 3 2011-09-23 06:32:06 PDT
Is this patch still relevant, Alex?
Philippe Normand
Comment 4 2012-02-11 00:24:52 PST
databaseDirectory now uses GOwnPtr and I don't think those calls need to be guarded by ENABLE(DATABASE), the webkit_set_web_database_directory_path function is already guarded by ENABLE(SQL_DATABASE). WebCore::cacheStorage().setCacheDirectory() doesn't need guards either, afaict. Closing this bug, feel free to reopen if needed :)
Note You need to log in before you can comment on or make changes to this bug.