Bug 59593 - Web Inspector: provide a hotkey for script pause
Summary: Web Inspector: provide a hotkey for script pause
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Alexander Pavlov (apavlov)
Depends on:
Reported: 2011-04-27 03:10 PDT by Yury Semikhatsky
Modified: 2011-04-28 06:03 PDT (History)
11 users (show)

See Also:

[PATCH] Suggested fix (2.03 KB, patch)
2011-04-28 04:31 PDT, Alexander Pavlov (apavlov)
yurys: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yury Semikhatsky 2011-04-27 03:10:25 PDT
We have hotkeys for stepping and continue, it looks logical to have one for script pause.

There is a user request for this: http://groups.google.com/a/chromium.org/group/chromium-discuss/browse_thread/thread/c5bde640f8281002/63410885d71aef6d
Comment 1 Alexander Pavlov (apavlov) 2011-04-28 00:59:25 PDT
F8 is the key, as it is bound to the Pause/Continue button click handler. If the same key for the two actions is deemed OK, we just need to update the shortcuts help page.
Comment 2 Alexander Pavlov (apavlov) 2011-04-28 04:31:06 PDT
Created attachment 91471 [details]
[PATCH] Suggested fix

This fixes the shortcuts help page for F8.
Comment 3 WebKit Review Bot 2011-04-28 04:34:00 PDT
Attachment 91471 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/ChangeLog:8:  Line contains tab character.  [whitespace/tab] [5]
Source/WebCore/ChangeLog:9:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 2 in 2 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Alexander Pavlov (apavlov) 2011-04-28 06:03:47 PDT
Committed r85179: <http://trac.webkit.org/changeset/85179>