Bug 59592 - Web Inspector: [Chromium] Implement retaining path following
Summary: Web Inspector: [Chromium] Implement retaining path following
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Mikhail Naganov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-27 02:54 PDT by Mikhail Naganov
Modified: 2011-04-28 08:56 PDT (History)
13 users (show)

See Also:


Attachments
patch (12.68 KB, patch)
2011-04-27 02:57 PDT, Mikhail Naganov
yurys: review+
mnaganov: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mikhail Naganov 2011-04-27 02:54:18 PDT
When retained paths are displayed, it would be convenient to be able to follow the path in the "Containment" view to look for object neighborhood.
Comment 1 Mikhail Naganov 2011-04-27 02:57:23 PDT
Created attachment 91259 [details]
patch
Comment 2 Mikhail Naganov 2011-04-28 08:00:20 PDT
Manually committed http://trac.webkit.org/changeset/85183


2011-04-28  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Yury Semikhatsky.

        WebInspector: [Chromium] Implement retaining paths following in detailed heap snapshots.
        https://bugs.webkit.org/show_bug.cgi?id=59592

        * inspector/front-end/DetailedHeapshotGridNodes.js:
        (WebInspector.HeapSnapshotGridNode.prototype._populate):
        (WebInspector.HeapSnapshotGridNode.prototype.populateChildren.childrenRetrieved):
        (WebInspector.HeapSnapshotGridNode.prototype.populateChildren.callSerialize):
        (WebInspector.HeapSnapshotGridNode.prototype.populateChildren):
        * inspector/front-end/DetailedHeapshotView.js:
        (WebInspector.HeapSnapshotContainmentDataGrid.prototype._defaultPopulateCount.100.expandRoute.nextStep.else.afterExpand):
        (WebInspector.HeapSnapshotContainmentDataGrid.prototype._defaultPopulateCount.100.expandRoute):
        (WebInspector.HeapSnapshotRetainingPathsList.prototype.showNext.pathFound):
        (WebInspector.DetailedHeapshotView.prototype._mouseClickInRetainmentGrid.expandRoute):
        (WebInspector.DetailedHeapshotView.prototype._mouseClickInRetainmentGrid):
        (WebInspector.DetailedHeapshotView.prototype.changeView.sortingComplete):
        (WebInspector.DetailedHeapshotView.prototype.changeView):
        * inspector/front-end/HeapSnapshot.js:
        (WebInspector.HeapSnapshotPathFinder.prototype.findNext):
        (WebInspector.HeapSnapshotPathFinder.prototype._nextEdgeIter):
        (WebInspector.HeapSnapshotPathFinder.prototype._buildNextPath):
        (WebInspector.HeapSnapshotPathFinder.prototype._pathToString):
        (WebInspector.HeapSnapshotPathFinder.prototype._pathToRoute):
        * inspector/front-end/heapProfiler.css:
        (div.retaining-paths-view td.path-column div:hover):

2011-04-28  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Yury Semikhatsky.

        WebInspector: [Chromium] Implement retaining paths following in detailed heap snapshots.
        https://bugs.webkit.org/show_bug.cgi?id=59592

        * inspector/profiler/detailed-heapshots-test.js:
        (initialize_DetailedHeapshotTest):
Comment 3 WebKit Review Bot 2011-04-28 08:56:40 PDT
http://trac.webkit.org/changeset/85183 might have broken Qt Linux Release
The following tests are not passing:
http/tests/inspector/resource-tree/resource-tree-frame-add.html
http/tests/inspector/resource-tree/resource-tree-frame-navigate.html
http/tests/inspector/resource-tree/resource-tree-reload.html