Bug 59590 – Web Inspector: clicking bookmarklet multiplies resources panel entries.

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Pavel Feldman]

Patch to follow.

[Pavel Feldman]

Created attachment 91271 [details]
Patch

[Yury Semikhatsky]

Comment on attachment 91271 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=91271&action=review

> Source/WebCore/ChangeLog:19
> [phone]  Pavel Feldman  <[e-mail]>

poor merge?

> Source/WebCore/inspector/front-end/ResourceTreeModel.js:73
>          this.dispatchEventToListeners(WebInspector.ResourceTreeModel.EventTypes.CachedResourcesLoaded);

Can we get rid of this call in favor of _frameNavigated?

[Pavel Feldman]

Created attachment 91273 [details]
Patch

[Yury Semikhatsky]

Comment on attachment 91273 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=91273&action=review

> Source/WebCore/inspector/front-end/ResourceTreeModel.js:136
>              WebInspector.mainResource = this.resourceForURL(frame.url);

Can you swap this line with the one above?

> Source/WebCore/inspector/front-end/ResourcesPanel.js:1017
> +        this._treeElementForResource[resource.url] = resourceTreeElement;

I'd rather move it to the beginning of the method.

> Source/WebCore/inspector/front-end/ResourcesPanel.js:1022
> +        WebInspector.BaseStorageTreeElement.prototype.removeChildren.call();

call(this)

[Pavel Feldman]

Committed r85048: <http://trac.webkit.org/changeset/85048>

[Csaba Osztrogonác]

It seems that a test need rebaseline after this patch.
Could you confirm it?

--- /Volumes/Data/WebKit-BuildSlave/snowleopard-intel-release-tests/build/layout-test-results/inspector/extensions/extensions-events-expected.txt	2011-04-27 05:54:26.000000000 -0700
+++ /Volumes/Data/WebKit-BuildSlave/snowleopard-intel-release-tests/build/layout-test-results/inspector/extensions/extensions-events-actual.txt	2011-04-27 05:54:26.000000000 -0700
@@ -5,8 +5,8 @@
 RUNNING TEST: extension_testOnNavigated
 Page reloaded.
 Page reloaded.
-Navigated to: extensions-events.html
 Navigated to: extensions-events.html?navigated
+Navigated to: extensions-events.html
 RUNNING TEST: extension_testOnResourceFinished
 onFinished fired
 RUNNING TEST: extension_testOnSelectionChanged

[WebKit Review Bot]

http://trac.webkit.org/changeset/85048 might have broken SnowLeopard Intel Release (Tests)
The following tests are not passing:
inspector/extensions/extensions-events.html