Bug 59586 - [GTK][Qt] fast/events/keydown-1.html fails
Summary: [GTK][Qt] fast/events/keydown-1.html fails
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P3 Normal
Assignee: Chang Shu
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2011-04-27 00:57 PDT by Martin Robinson
Modified: 2011-05-02 15:20 PDT (History)
2 users (show)

See Also:


Attachments
fix patch (2.53 KB, patch)
2011-05-02 13:39 PDT, Chang Shu
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2011-04-27 00:57:22 PDT
The period is not missing from the end of the sentence, as the test suggests.

--- /tmp/layout-test-results/fast/events/keydown-1-expected.txt	2011-04-27 00:56:22.484711997 -0700
+++ /tmp/layout-test-results/fast/events/keydown-1-actual.txt	2011-04-27 00:56:22.484711997 -0700
@@ -3,4 +3,4 @@
 
 keydown in subframe: [object KeyboardEvent]
 keydown in subframe: [object KeyboardEvent]
-This sentence should not end with a period
+This sentence should not end with a period.
Comment 1 Alexey Proskuryakov 2011-04-27 10:15:39 PDT
FWIW, the test was converted to text only in <trac.webkit.org/r84897>. This looks more like an actual bug in the port at a first glance though.
Comment 2 Martin Robinson 2011-04-27 10:20:12 PDT
(In reply to comment #1)
> FWIW, the test was converted to text only in <trac.webkit.org/r84897>. This looks more like an actual bug in the port at a first glance though.

Yes, even before the text conversion this test was incredibly flaky across different machines. The text conversion provides good impetus to finally squash this bug.
Comment 3 Chang Shu 2011-04-27 10:34:58 PDT
I believe so. The pixel result may falsely consider it's passing because one dot doesn't contribute much in the whole image.
This test also fails on Qt but it was skipped. I suspect it's a key binding issue. Probably we should rewrite the test to use common key codes.
Comment 4 Chang Shu 2011-05-02 13:39:23 PDT
Created attachment 91970 [details]
fix patch
Comment 5 Martin Robinson 2011-05-02 13:48:44 PDT
Comment on attachment 91970 [details]
fix patch

Thanks!
Comment 6 WebKit Commit Bot 2011-05-02 15:19:08 PDT
The commit-queue encountered the following flaky tests while processing attachment 91970 [details]:

inspector/debugger/debugger-scripts.html bug 59921 (authors: pfeldman@chromium.org and podivilov@chromium.org)
The commit-queue is continuing to process your patch.
Comment 7 WebKit Commit Bot 2011-05-02 15:20:32 PDT
Comment on attachment 91970 [details]
fix patch

Clearing flags on attachment: 91970

Committed r85528: <http://trac.webkit.org/changeset/85528>
Comment 8 WebKit Commit Bot 2011-05-02 15:20:37 PDT
All reviewed patches have been landed.  Closing bug.