Webkit trunk r85024 build fails with both clang & gcc-4.6.0, the error is: make[1]: Entering directory `/mnt/mnt/backup/sources/webkit' CXX Source/WebKit/gtk/WebCoreSupport/libwebkitgtk_1_0_la-TextCheckerClientEnchant.lo In file included from Source/WebKit/gtk/WebCoreSupport/TextCheckerClientEnchant.cpp:29: ./Source/WebKit/gtk/webkit/webkitwebviewprivate.h:34:10: error: no type named 'Page' in namespace 'WebCore' WebCore::Page* core(WebKitWebView*); ~~~~~~~~~^ ./Source/WebKit/gtk/webkit/webkitwebviewprivate.h:35:29: error: no member named 'Page' in namespace 'WebCore' WebKitWebView* kit(WebCore::Page*); ~~~~~~~~~^ ./Source/WebKit/gtk/webkit/webkitwebviewprivate.h:35:34: error: expected expression WebKitWebView* kit(WebCore::Page*); ^ ./Source/WebKit/gtk/webkit/webkitwebviewprivate.h:54:14: error: no type named 'Page' in namespace 'WebCore' WebCore::Page* corePage; ~~~~~~~~~^ 4 errors generated. make[1]: *** [Source/WebKit/gtk/WebCoreSupport/libwebkitgtk_1_0_la-TextCheckerClientEnchant.lo] Error 1 make[1]: Leaving directory `/mnt/mnt/backup/sources/webkit' make: *** [all] Error 2
Created attachment 91250 [details] #include "Page.h" fixes the issue.
Comment on attachment 91250 [details] #include "Page.h" fixes the issue. Would you be willing to include and fill out a ChangeLog with this patch. Please see the instructions at: http://www.webkit.org/coding/contributing.html
Created attachment 91458 [details] '#include "Page.h" ' in webkitwebviewprivate.h This time with Changelog & created with svn-create-patch.
Comment on attachment 91458 [details] '#include "Page.h" ' in webkitwebviewprivate.h View in context: https://bugs.webkit.org/attachment.cgi?id=91458&action=review > Source/WebKit/gtk/webkit/webkitwebviewprivate.h:29 > #include "GOwnPtr.h" The style guidelines say this must be in alphabetical order. Sorry I didn't mention it before. I'll land this and fix it.
Committed r85221: <http://trac.webkit.org/changeset/85221>