Bug 59577 – if both border-radius and box-shadow applied, shadow is not fully visible

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Petr Gajdůšek]

Hi,

Have a box with border-radius applied for its top <right|left> and/or bottom <right|left> corners,
be the border-radius length set to the exactly same (or greater) value as the height of the box.

Something like these CSS rules:
#box {
  height: 30px;
  border-radius: 0 0 30px 30px;
}

Now if you apply box-shadow to #box, that shadow is not displayed properly - 
it is not displayed in that box parts that are cut off by border-radius,
instead underlying layer is visible (i.e. body background color).

Lowering the shadow length by single pixel works ok.

Example (XHTML attached):

HTML:
<div id="shadowed_box"></div>

CSS:
#shadowed_box {
  height: 30px;
  border-radius: 30px 0;
  box-shadow: 4px 4px 8px black;
  background-color: red;
}

I had this issue with every webkit version (with border-shadow support) I tried (latest nightly build r84622 including)
on Debian 32bit (chromium, epiphany) and Win7 64bit (google chrome, safari + nightly webkit).

Regards,
Petr

[Petr Gajdůšek]

Created attachment 91224 [details]
testcase

[Petr Gajdůšek]

Created attachment 91225 [details]
testcase

[Kulanthaivel Palanichamy]

Created attachment 94155 [details]
Proposed patch.

[Simon Fraser (smfr)]

Comment on attachment 94155 [details]
Proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=94155&action=review

> Source/WebCore/platform/graphics/RoundedIntRect.cpp:81
> +    float factor = 0;

No need to initialize this here. You should also move this line to just above the if () test below.

[Kulanthaivel Palanichamy]

Created attachment 94271 [details]
Proposed patch.

[WebKit Commit Bot]

Comment on attachment 94271 [details]
Proposed patch.

Rejecting attachment 94271 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-7', 'build-..." exit_code: 2

Last 500 characters of output:
tmlmp .
http/tests/xmlhttprequest ................................................................................................................................................................................
http/tests/xmlhttprequest/web-apps ...............
http/tests/xmlhttprequest/workers ...........
http/tests/xmlviewer .
http/tests/xmlviewer/dumpAsText ...........
739.88s total testing time

23588 test cases (99%) succeeded
1 test case (<1%) was new
14 test cases (<1%) had stderr output

Full output: http://queues.webkit.org/results/8721452

[WebKit Commit Bot]

Created attachment 94298 [details]
Archive of layout-test-results from cr-jail-7

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: cr-jail-7  Port: Mac  Platform: Mac OS X 10.6.7

[Julien Chaffraix]

Manually landed the patch in r87006.