Bug 59567 - Add a few more missing options to new-run-webkit-tests
Summary: Add a few more missing options to new-run-webkit-tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-26 18:14 PDT by Sam Weinig
Modified: 2011-04-27 16:54 PDT (History)
6 users (show)

See Also:

Attachments
Patch (5.25 KB, patch)
2011-04-26 18:17 PDT, Sam Weinig 		levin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2011-04-26 18:14:54 PDT 
Add a few more missing options to new-run-webkit-tests
Comment 1 Sam Weinig 2011-04-26 18:17:28 PDT 
Created attachment 91198 [details]
Patch
Comment 2 WebKit Review Bot 2011-04-26 18:20:34 PDT 
Attachment 91198 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/webkitpy..." exit_code: 1

Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:264:  whitespace before ']'  [pep8/E202] [5]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 David Levin 2011-04-27 12:50:16 PDT 
Seems fine but adding a few more discerning eyes.
Comment 4 Dirk Pranke 2011-04-27 13:02:23 PDT 
looks fine to me.
Comment 5 Sam Weinig 2011-04-27 16:17:50 PDT 
Committed r85119: <http://trac.webkit.org/changeset/85119>
Comment 6 WebKit Review Bot 2011-04-27 16:54:27 PDT 
http://trac.webkit.org/changeset/85119 might have broken Qt Linux Release