Bug 59545 - sherrifbot create-bug shouldn't assign bugs to webkit.review.bot
Summary: sherrifbot create-bug shouldn't assign bugs to webkit.review.bot
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-26 15:11 PDT by WebKit Review Bot
Modified: 2011-04-27 11:17 PDT (History)
6 users (show)

See Also:


Attachments
Patch (14.77 KB, patch)
2011-04-26 23:26 PDT, Eric Seidel (no email)
no flags Details | Formatted Diff | Diff
Patch for landing (19.02 KB, patch)
2011-04-27 08:45 PDT, Eric Seidel (no email)
no flags Details | Formatted Diff | Diff
Patch for landing (19.32 KB, patch)
2011-04-27 08:49 PDT, Eric Seidel (no email)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description WebKit Review Bot 2011-04-26 15:11:04 PDT
sherrifbot create-bug shouldn't assign bugs to webkit.review.bot
Requested by aroben on #webkit.
Comment 1 Alexey Proskuryakov 2011-04-26 19:40:33 PDT
See also: bug 59575.
Comment 2 Eric Seidel (no email) 2011-04-26 23:26:05 PDT
Created attachment 91240 [details]
Patch
Comment 3 Mihai Parparita 2011-04-27 07:49:43 PDT
Comment on attachment 91240 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=91240&action=review

> Tools/Scripts/webkitpy/common/config/committers.py:391
> +            if contributor.full_name and contributor.full_name == name:

Why the check if contributor.full_name is non-empty? Presumably the name argument will be non-empty, so the equality check should take care of that.

> Tools/Scripts/webkitpy/common/config/committers.py:400
> +            if contributor.irc_nickname and contributor.irc_nickname == irc_nickname:

Ditto here.

> Tools/Scripts/webkitpy/common/config/committers.py:404
> +    def contributor_by_email(self, email):

Now that you have this, perhaps the committer_by_email call in the whois command should also be changed to support contributors?
Comment 4 Eric Seidel (no email) 2011-04-27 08:18:23 PDT
(In reply to comment #3)
> (From update of attachment 91240 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=91240&action=review
> 
> > Tools/Scripts/webkitpy/common/config/committers.py:391
> > +            if contributor.full_name and contributor.full_name == name:
> 
> Why the check if contributor.full_name is non-empty? Presumably the name argument will be non-empty, so the equality check should take care of that.

Originally I added an assert(name) to that function.  However, current code violates that.  (Which is OK, since full_name can never be empty.)  I wanted to make sure that future code didn't end up allowing None full_name and causing this function to do strange things.

> > Tools/Scripts/webkitpy/common/config/committers.py:400
> > +            if contributor.irc_nickname and contributor.irc_nickname == irc_nickname:
> 
> Ditto here.

None is a valid value for irc_nickname however.  But it doesn't make sense to search for a none nickname.  I could assert that argument irc_nickname is never None, but that seemed to be confusing when compared with contributor_by_name().

> > Tools/Scripts/webkitpy/common/config/committers.py:404
> > +    def contributor_by_email(self, email):
> 
> Now that you have this, perhaps the committer_by_email call in the whois command should also be changed to support contributors?

Happy to make that change!
Comment 5 Eric Seidel (no email) 2011-04-27 08:45:10 PDT
Created attachment 91290 [details]
Patch for landing
Comment 6 Eric Seidel (no email) 2011-04-27 08:49:13 PDT
Created attachment 91291 [details]
Patch for landing
Comment 7 WebKit Commit Bot 2011-04-27 11:15:21 PDT
The commit-queue encountered the following flaky tests while processing attachment 91291 [details]:

http/tests/xmlhttprequest/basic-auth.html bug 51613 (author: ap@webkit.org)
The commit-queue is continuing to process your patch.
Comment 8 WebKit Commit Bot 2011-04-27 11:17:01 PDT
Comment on attachment 91291 [details]
Patch for landing

Clearing flags on attachment: 91291

Committed r85065: <http://trac.webkit.org/changeset/85065>
Comment 9 WebKit Commit Bot 2011-04-27 11:17:06 PDT
All reviewed patches have been landed.  Closing bug.