RESOLVED FIXED Bug 59497
Port Mozilla's IndexedDB tests: bad keypath 
https://bugs.webkit.org/show_bug.cgi?id=59497
Summary Port Mozilla's IndexedDB tests: bad keypath
Mark Pilgrim (Google)
Reported 2011-04-26 14:24:09 PDT
Original test: http://mxr.mozilla.org/mozilla2.0/source/dom/indexedDB/test/test_bad_keypath.html?force=1 This is a port of a test from Mozilla's IndexedDB test suite. It checks the add() method with and without a valid keypath. WebKit passes this test.
Attachments
patch with changelog and layouttest (4.47 KB, patch)
2011-04-26 14:25 PDT, Mark Pilgrim (Google) 		tony: review+
DetailsFormatted DiffDiff
rebase webkit directory (4.30 KB, patch)
2011-04-26 19:42 PDT, Mark Pilgrim (Google) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mark Pilgrim (Google)
Comment 1 2011-04-26 14:25:03 PDT
Created attachment 91164 [details] patch with changelog and layouttest
Tony Chang
Comment 2 2011-04-26 16:37:55 PDT
Comment on attachment 91164 [details] patch with changelog and layouttest Just a reminder that we'll need to rebase these patches against the root of the webkit repo if we want the commit queue to land them.
Mark Pilgrim (Google)
Comment 3 2011-04-26 18:33:02 PDT
Can you explain what I'm doing wrong that the patches need to be rebased? I'm entirely new at this.
Mark Pilgrim (Google)
Comment 4 2011-04-26 19:42:31 PDT
Created attachment 91218 [details] rebase webkit directory
Mark Pilgrim (Google)
Comment 5 2011-04-26 19:43:25 PDT
(In reply to comment #3) > Can you explain what I'm doing wrong that the patches need to be rebased? I'm entirely new at this. Never mind, the fine folks in IRC explained it. I've munged this patch manually as per their instructions. Future patches should be based in the proper root directory.
WebKit Commit Bot
Comment 6 2011-04-27 16:46:27 PDT
The commit-queue encountered the following flaky tests while processing attachment 91218 [details]: http/tests/xmlhttprequest/simple-cross-origin-progress-events.html bug 54798 (authors: ap@webkit.org and levin@chromium.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 7 2011-04-27 16:48:26 PDT
Comment on attachment 91218 [details] rebase webkit directory Clearing flags on attachment: 91218 Committed r85121: <http://trac.webkit.org/changeset/85121>
WebKit Commit Bot
Comment 8 2011-04-27 16:48:31 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 9 2011-04-27 17:30:45 PDT
http://trac.webkit.org/changeset/85121 might have broken SnowLeopard Intel Release (Tests)
Note You need to log in before you can comment on or make changes to this bug.