Bug 59497 - Port Mozilla's IndexedDB tests: bad keypath
Summary: Port Mozilla's IndexedDB tests: bad keypath
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P3 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-26 14:24 PDT by Mark Pilgrim (Google)
Modified: 2011-04-27 17:30 PDT (History)
9 users (show)

See Also:


Attachments
patch with changelog and layouttest (4.47 KB, patch)
2011-04-26 14:25 PDT, Mark Pilgrim (Google)
tony: review+
Details | Formatted Diff | Diff
rebase webkit directory (4.30 KB, patch)
2011-04-26 19:42 PDT, Mark Pilgrim (Google)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Pilgrim (Google) 2011-04-26 14:24:09 PDT
Original test: http://mxr.mozilla.org/mozilla2.0/source/dom/indexedDB/test/test_bad_keypath.html?force=1

This is a port of a test from Mozilla's IndexedDB test suite. It checks the add() method with and without a valid keypath. WebKit passes this test.
Comment 1 Mark Pilgrim (Google) 2011-04-26 14:25:03 PDT
Created attachment 91164 [details]
patch with changelog and layouttest
Comment 2 Tony Chang 2011-04-26 16:37:55 PDT
Comment on attachment 91164 [details]
patch with changelog and layouttest

Just a reminder that we'll need to rebase these patches against the root of the webkit repo if we want the commit queue to land them.
Comment 3 Mark Pilgrim (Google) 2011-04-26 18:33:02 PDT
Can you explain what I'm doing wrong that the patches need to be rebased? I'm entirely new at this.
Comment 4 Mark Pilgrim (Google) 2011-04-26 19:42:31 PDT
Created attachment 91218 [details]
rebase webkit directory
Comment 5 Mark Pilgrim (Google) 2011-04-26 19:43:25 PDT
(In reply to comment #3)
> Can you explain what I'm doing wrong that the patches need to be rebased? I'm entirely new at this.

Never mind, the fine folks in IRC explained it. I've munged this patch manually as per their instructions. Future patches should be based in the proper root directory.
Comment 6 WebKit Commit Bot 2011-04-27 16:46:27 PDT
The commit-queue encountered the following flaky tests while processing attachment 91218 [details]:

http/tests/xmlhttprequest/simple-cross-origin-progress-events.html bug 54798 (authors: ap@webkit.org and levin@chromium.org)
The commit-queue is continuing to process your patch.
Comment 7 WebKit Commit Bot 2011-04-27 16:48:26 PDT
Comment on attachment 91218 [details]
rebase webkit directory

Clearing flags on attachment: 91218

Committed r85121: <http://trac.webkit.org/changeset/85121>
Comment 8 WebKit Commit Bot 2011-04-27 16:48:31 PDT
All reviewed patches have been landed.  Closing bug.
Comment 9 WebKit Review Bot 2011-04-27 17:30:45 PDT
http://trac.webkit.org/changeset/85121 might have broken SnowLeopard Intel Release (Tests)