Bug 59480 - InlineBox.h shouldn't include RenderBR.h
Summary: InlineBox.h shouldn't include RenderBR.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Mihai Parparita
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-26 12:05 PDT by Mihai Parparita
Modified: 2011-04-26 14:22 PDT (History)
3 users (show)

See Also:

Attachments
Patch (2.12 KB, patch)
2011-04-26 12:06 PDT, Mihai Parparita 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mihai Parparita 2011-04-26 12:05:04 PDT 
InlineBox.h shouldn't include RenderBR.h
Comment 1 Mihai Parparita 2011-04-26 12:06:41 PDT 
Created attachment 91141 [details]
Patch
Comment 2 Nico Weber 2011-04-26 13:05:15 PDT 
Cool! You could add something like "this reduces the size of InlineBox.h by XXX kB" to the ChangeLog entry. You get the XXX from eric's script attached to bug 59348.
Comment 3 Mihai Parparita 2011-04-26 14:06:50 PDT 
Before: Source/WebCore/rendering/InlineBox.h: 0.917 247 226.499000 (from bug 59348)
After: Source/WebCore/rendering/InlineBox.h: 0.906 247 223.782000

So it's only 11K in the .h file, and 3MB across all the includes?
Comment 4 Nico Weber 2011-04-26 14:11:43 PDT 
Looks like it. Probably because InlineBox.h and RenderBR.h include similar files. :-/
Comment 5 WebKit Commit Bot 2011-04-26 14:22:07 PDT 
Comment on attachment 91141 [details]
Patch

Clearing flags on attachment: 91141

Committed r84956: <http://trac.webkit.org/changeset/84956>
Comment 6 WebKit Commit Bot 2011-04-26 14:22:12 PDT 
All reviewed patches have been landed.  Closing bug.