Bug 59472 - Port Mozilla's IndexedDB tests: index cursors
Summary: Port Mozilla's IndexedDB tests: index cursors
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P3 Normal
Assignee: Nobody
Depends on:
Reported: 2011-04-26 11:14 PDT by Mark Pilgrim (Google)
Modified: 2011-04-27 21:56 PDT (History)
6 users (show)

See Also:

patch with changelog and layouttest (9.43 KB, patch)
2011-04-26 11:21 PDT, Mark Pilgrim (Google)
no flags Details | Formatted Diff | Diff
Patch (6.06 KB, patch)
2011-04-27 13:32 PDT, Mark Pilgrim (Google)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Pilgrim (Google) 2011-04-26 11:14:37 PDT
Original tests: http://mxr.mozilla.org/mozilla2.0/source/dom/indexedDB/test/test_objectCursors.html?force=1

This is a pair of tests ported from Mozilla's IndexedDB test suite. It checks some basic properties of index cursors. WebKit passes these tests.
Comment 1 Mark Pilgrim (Google) 2011-04-26 11:21:45 PDT
Created attachment 91130 [details]
patch with changelog and layouttest
Comment 2 Tony Chang 2011-04-26 16:28:18 PDT
Comment on attachment 91130 [details]
patch with changelog and layouttest

View in context: https://bugs.webkit.org/attachment.cgi?id=91130&action=review

I suspect the bot will have a hard time landing these patches since the root of the diff isn't the root of the webkit repo.

> third_party/WebKit/LayoutTests/storage/indexeddb/mozilla/object-cursors-autoincrement.html:20
> +description("Test IndexedDB's index cursors");

Nit: Should this mention autoincrement (to help differentiate it from object-cursors.html)?

> third_party/WebKit/LayoutTests/storage/indexeddb/mozilla/object-cursors.html:1
> +<!DOCTYPE html>

These tests look almost identical.  Can we make it into a single test file to avoid the code repetition?
Comment 3 Mark Pilgrim (Google) 2011-04-27 13:32:25 PDT
Created attachment 91335 [details]
Comment 4 Mark Pilgrim (Google) 2011-04-27 13:36:29 PDT
I believe this patch is now rooted properly. I combined the two tests into one file and added logged autoIncrement=true/false statements to differentiate between the tests.
Comment 5 WebKit Commit Bot 2011-04-27 21:56:06 PDT
Comment on attachment 91335 [details]

Clearing flags on attachment: 91335

Committed r85150: <http://trac.webkit.org/changeset/85150>
Comment 6 WebKit Commit Bot 2011-04-27 21:56:11 PDT
All reviewed patches have been landed.  Closing bug.