Bug 59466 – Incorrect OwnPtr usage in MediaPlayer

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Adrienne Walker]

As part of the work to remove the LOOSE_OWN_PTR #define in OwnPtr.h, I was looking at Source/WebCore/platform/graphics/MediaPlayer* and saw this:

    OwnPtr<MediaPlayerPrivateInterface*> m_private;

It seems to be an error to me to store a raw pointer in an OwnPtr and that this really was intended to be OwnPtr<MediaPlayerPrivateInterface>.  

I don't know if it's possible, but it'd also probably be nice to change the CreateMediaEnginePlayer interface to return a PassOwnPtr<MediaPlayerPrivateInterface> too.

[Patrick R. Gansterer]

Created attachment 93213 [details]
Patch

[Adam Barth]

Comment on attachment 93213 [details]
Patch

Fantastic.  Thanks!

[WebKit Review Bot]

Comment on attachment 93213 [details]
Patch

Attachment 93213 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/8690451

[Adrienne Walker]

In retrospect, I was confused about OwnPtr<T*> which turns out to be exactly equivalent to OwnPtr<T> thanks to template magic.  Its only sin is that it's stylistically confusing.

The only bit of this patch that really needs to be there is to just remove the LOOSE_OWN_PTR #define and fix the few lines that break because of it.  Changing the CreateMediaEnginePlayer interface is probably not necessary.

[Patrick R. Gansterer]

(In reply to comment #4)
> The only bit of this patch that really needs to be there is to just remove the LOOSE_OWN_PTR #define and fix the few lines that break because of it.  Changing the CreateMediaEnginePlayer interface is probably not necessary.
adoptPtr should be done directly when calling new, so we need to change CreateMediaEnginePlayer too.

[Patrick R. Gansterer]

Created attachment 93227 [details]
Patch

[WebKit Review Bot]

Comment on attachment 93227 [details]
Patch

Attachment 93227 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/8685589

[Gustavo Noronha (kov)]

Comment on attachment 93227 [details]
Patch

Attachment 93227 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/8688764

[Patrick R. Gansterer]

Created attachment 93355 [details]
Patch

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 93355 [details]:

inspector/debugger/debugger-scripts.html bug 59921 (authors: [e-mail] and [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 93355 [details]
Patch

Clearing flags on attachment: 93355

Committed r86418: <http://trac.webkit.org/changeset/86418>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.