Bug 59464 - Fix more strict OwnPtr in WebCore (round N).
Summary: Fix more strict OwnPtr in WebCore (round N).
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: David Levin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-26 09:22 PDT by David Levin
Modified: 2011-04-26 10:17 PDT (History)
1 user (show)

See Also:


Attachments
Patch (4.44 KB, patch)
2011-04-26 09:23 PDT, David Levin
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Levin 2011-04-26 09:22:56 PDT
Fix more strict OwnPtr in WebCore (round N).
Comment 1 David Levin 2011-04-26 09:23:26 PDT
Created attachment 91117 [details]
Patch
Comment 2 Darin Adler 2011-04-26 09:48:52 PDT
Comment on attachment 91117 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=91117&action=review

> Source/WebCore/fileapi/FileReader.cpp:171
> -        m_loader = 0;
> +        m_loader.clear();

Anders Carlsson would much prefer that we use "= nullptr" rather than "clear()".

> Source/WebCore/loader/DocumentThreadableLoader.cpp:334
> -    m_actualRequest = 0; // Prevent didFinishLoading() from bypassing access check.
> +    m_actualRequest.clear(); // Prevent didFinishLoading() from bypassing access check.

Ditto.
Comment 3 David Levin 2011-04-26 10:17:13 PDT
Committed as http://trac.webkit.org/changeset/84923