Bug 59455 - Web Inspector: implement incremental CSS editing in the structure view.
Summary: Web Inspector: implement incremental CSS editing in the structure view.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-26 07:44 PDT by Pavel Feldman
Modified: 2011-04-27 01:34 PDT (History)
10 users (show)

See Also:


Attachments
Patch (3.27 KB, patch)
2011-04-26 07:46 PDT, Pavel Feldman
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2011-04-26 07:44:35 PDT
Patch to follow.
Comment 1 Pavel Feldman 2011-04-26 07:46:20 PDT
Created attachment 91105 [details]
Patch
Comment 2 Alexander Pavlov (apavlov) 2011-04-26 07:49:44 PDT
Comment on attachment 91105 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=91105&action=review

> Source/WebCore/inspector/front-end/StylesSidebarPane.js:1699
> +        if (this._handleUpOrDownKeyPressed(event))

A good idea is to align this with _applyFreeFlowStyleTextEdit (just remove the model modification code from _handleUpOrDownKeyPressed and call _apply...() unconditionally).
Comment 3 Pavel Feldman 2011-04-26 09:38:48 PDT
Comment on attachment 91105 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=91105&action=review

>> Source/WebCore/inspector/front-end/StylesSidebarPane.js:1699
>> +        if (this._handleUpOrDownKeyPressed(event))
> 
> A good idea is to align this with _applyFreeFlowStyleTextEdit (just remove the model modification code from _handleUpOrDownKeyPressed and call _apply...() unconditionally).

I think increments should be processed synchronously, with no delay
Comment 4 Pavel Feldman 2011-04-27 01:34:32 PDT
Comment on attachment 91105 [details]
Patch

Clearing flags on attachment: 91105

Committed r85034: <http://trac.webkit.org/changeset/85034>
Comment 5 Pavel Feldman 2011-04-27 01:34:41 PDT
All reviewed patches have been landed.  Closing bug.