RESOLVED FIXED 59455
Web Inspector: implement incremental CSS editing in the structure view. 
https://bugs.webkit.org/show_bug.cgi?id=59455
Summary Web Inspector: implement incremental CSS editing in the structure view.
Pavel Feldman
Reported 2011-04-26 07:44:35 PDT
Patch to follow.
Attachments
Patch (3.27 KB, patch)
2011-04-26 07:46 PDT, Pavel Feldman 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2011-04-26 07:46:20 PDT
Created attachment 91105 [details] Patch
Alexander Pavlov (apavlov)
Comment 2 2011-04-26 07:49:44 PDT
Comment on attachment 91105 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=91105&action=review > Source/WebCore/inspector/front-end/StylesSidebarPane.js:1699 > + if (this._handleUpOrDownKeyPressed(event)) A good idea is to align this with _applyFreeFlowStyleTextEdit (just remove the model modification code from _handleUpOrDownKeyPressed and call _apply...() unconditionally).
Pavel Feldman
Comment 3 2011-04-26 09:38:48 PDT
Comment on attachment 91105 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=91105&action=review >> Source/WebCore/inspector/front-end/StylesSidebarPane.js:1699 >> + if (this._handleUpOrDownKeyPressed(event)) > > A good idea is to align this with _applyFreeFlowStyleTextEdit (just remove the model modification code from _handleUpOrDownKeyPressed and call _apply...() unconditionally). I think increments should be processed synchronously, with no delay
Pavel Feldman
Comment 4 2011-04-27 01:34:32 PDT
Comment on attachment 91105 [details] Patch Clearing flags on attachment: 91105 Committed r85034: <http://trac.webkit.org/changeset/85034>
Pavel Feldman
Comment 5 2011-04-27 01:34:41 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.