Bug 59451 - Web Inspector: New Style is not working (UI glitch)
Summary: Web Inspector: New Style is not working (UI glitch)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-26 06:07 PDT by Pavel Feldman
Modified: 2011-04-26 08:12 PDT (History)
14 users (show)

See Also:


Attachments
Patch (10.81 KB, patch)
2011-04-26 06:42 PDT, Pavel Feldman
no flags Details | Formatted Diff | Diff
Patch (11.97 KB, patch)
2011-04-26 07:02 PDT, Pavel Feldman
yurys: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2011-04-26 06:07:17 PDT
Patch to follow.
Comment 1 Pavel Feldman 2011-04-26 06:42:51 PDT
Created attachment 91096 [details]
Patch
Comment 2 Pavel Feldman 2011-04-26 07:02:34 PDT
Created attachment 91098 [details]
Patch
Comment 3 Yury Semikhatsky 2011-04-26 07:22:18 PDT
Comment on attachment 91098 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=91098&action=review

> Source/WebCore/inspector/front-end/CSSStyleModel.js:185
> +        var documentElement = node && node.ownerDocumentElement();

is it possible that ownerDocumentElement is undefined? if not prefer early return
Comment 4 Pavel Feldman 2011-04-26 07:24:20 PDT
Committed r84909: <http://trac.webkit.org/changeset/84909>
Comment 5 WebKit Review Bot 2011-04-26 07:57:08 PDT
http://trac.webkit.org/changeset/84909 might have broken SnowLeopard Intel Release (Tests)
Comment 6 Csaba Osztrogonác 2011-04-26 08:12:03 PDT
(In reply to comment #5)
> http://trac.webkit.org/changeset/84909 might have broken SnowLeopard Intel Release (Tests)

And Qt and I think other bots too.


--- /Volumes/Data/WebKit-BuildSlave/snowleopard-intel-release-tests/build/layout-test-results/http/tests/inspector-enabled/dom-storage-open-expected.txt	2011-04-26 07:46:48.000000000 -0700
+++ /Volumes/Data/WebKit-BuildSlave/snowleopard-intel-release-tests/build/layout-test-results/http/tests/inspector-enabled/dom-storage-open-actual.txt	2011-04-26 07:46:48.000000000 -0700
@@ -1,5 +1 @@
 Tests that Web Inspector gets populated with DOM storages that were opened before inspector is shown.
-
-Domain: 127.0.0.1
-IsLocalStorage: false
-