RESOLVED FIXED 59439
[Qt] Implement LayoutTestController::setAutofilled 
https://bugs.webkit.org/show_bug.cgi?id=59439
Summary [Qt] Implement LayoutTestController::setAutofilled
Kristóf Kosztyó
Reported 2011-04-26 02:44:37 PDT
[Qt] Implement LayoutTestController::setAutofilled
Attachments
proposed fix (5.56 KB, patch)
2011-04-26 04:59 PDT, Kristóf Kosztyó 		no flags
DetailsFormatted DiffDiff
proposed fix (5.99 KB, patch)
2011-04-26 05:18 PDT, Kristóf Kosztyó 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Kristóf Kosztyó
Comment 1 2011-04-26 04:59:42 PDT
Created attachment 91090 [details] proposed fix
WebKit Review Bot
Comment 2 2011-04-26 05:02:23 PDT
Attachment 91090 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1 Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.h:112: The parameter name "element" adds no information, so it should be removed. [readability/parameter_name] [5] Tools/DumpRenderTree/qt/LayoutTestControllerQt.h:154: The parameter name "element" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 2 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Kristóf Kosztyó
Comment 3 2011-04-26 05:18:44 PDT
Created attachment 91093 [details] proposed fix
Csaba Osztrogonác
Comment 4 2011-04-26 06:08:20 PDT
Comment on attachment 91093 [details] proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=91093&action=review LGTM, r=me. (Apart from some minor thing, what I'll fix before landing.) > LayoutTests/platform/qt/Skipped:-723 > -# Missing layoutTestController.overridePreference() > -fast/events/pageshow-pagehide-on-back-cached.html > -fast/events/pageshow-pagehide-on-back-cached-with-frames.html > - This change is unrelated to this bug. > Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp:246 > + return; Add a newline after it.
Csaba Osztrogonác
Comment 5 2011-04-26 06:22:19 PDT
Comment on attachment 91093 [details] proposed fix Landed in http://trac.webkit.org/changeset/84906
Note You need to log in before you can comment on or make changes to this bug.