Bug 59439 - [Qt] Implement LayoutTestController::setAutofilled
Summary: [Qt] Implement LayoutTestController::setAutofilled
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks:
 
Reported: 2011-04-26 02:44 PDT by Kristóf Kosztyó
Modified: 2011-04-26 06:23 PDT (History)
2 users (show)

See Also:

Attachments
proposed fix (5.56 KB, patch)
2011-04-26 04:59 PDT, Kristóf Kosztyó 		no flags Details | Formatted Diff | Diff
proposed fix (5.99 KB, patch)
2011-04-26 05:18 PDT, Kristóf Kosztyó 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kristóf Kosztyó 2011-04-26 02:44:37 PDT 
[Qt] Implement LayoutTestController::setAutofilled
Comment 1 Kristóf Kosztyó 2011-04-26 04:59:42 PDT 
Created attachment 91090 [details]
proposed fix
Comment 2 WebKit Review Bot 2011-04-26 05:02:23 PDT 
Attachment 91090 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1

Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.h:112:  The parameter name "element" adds no information, so it should be removed.  [readability/parameter_name] [5]
Tools/DumpRenderTree/qt/LayoutTestControllerQt.h:154:  The parameter name "element" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 2 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Kristóf Kosztyó 2011-04-26 05:18:44 PDT 
Created attachment 91093 [details]
proposed fix
Comment 4 Csaba Osztrogonác 2011-04-26 06:08:20 PDT 
Comment on attachment 91093 [details]
proposed fix

View in context: https://bugs.webkit.org/attachment.cgi?id=91093&action=review

LGTM, r=me. (Apart from some minor thing, what I'll fix before landing.)

> LayoutTests/platform/qt/Skipped:-723
> -# Missing layoutTestController.overridePreference()
> -fast/events/pageshow-pagehide-on-back-cached.html
> -fast/events/pageshow-pagehide-on-back-cached-with-frames.html
> -

This change is unrelated to this bug.

> Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp:246
> +        return;

Add a newline after it.
Comment 5 Csaba Osztrogonác 2011-04-26 06:22:19 PDT 
Comment on attachment 91093 [details]
proposed fix

Landed in http://trac.webkit.org/changeset/84906