Bug 59429 - Fix last strict OwnPtr violation under svg/...
Summary: Fix last strict OwnPtr violation under svg/...
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Adam Klein
Depends on:
Reported: 2011-04-26 00:13 PDT by Adam Klein
Modified: 2011-04-26 04:12 PDT (History)
4 users (show)

See Also:

Patch (1.44 KB, patch)
2011-04-26 00:13 PDT, Adam Klein
abarth: review+
abarth: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Klein 2011-04-26 00:13:07 PDT
Fix last strict OwnPtr violation under svg/...
Comment 1 Adam Klein 2011-04-26 00:13:37 PDT
Created attachment 91075 [details]
Comment 2 Adam Barth 2011-04-26 00:24:56 PDT
Comment on attachment 91075 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=91075&action=review

> Source/WebCore/svg/SVGDocumentExtensions.cpp:243
> -    OwnPtr<SVGPendingElements> set(m_pendingResources.get(id));
> +    OwnPtr<SVGPendingElements> set(adoptPtr(m_pendingResources.get(id)));

We prefer the assignment form of the constructor:

OwnPtr<SVGPendingElements> set = adoptPtr(m_pendingResources.get(id));
Comment 3 Adam Barth 2011-04-26 00:27:59 PDT
I can land this for you.
Comment 4 Adam Barth 2011-04-26 00:30:22 PDT
Committed r84891: <http://trac.webkit.org/changeset/84891>
Comment 5 WebKit Review Bot 2011-04-26 04:12:24 PDT
http://trac.webkit.org/changeset/84891 might have broken SnowLeopard Intel Release (WebKit2 Tests)