Bug 59425 - Nixed special finalizer handling for WebCore strings
Summary: Nixed special finalizer handling for WebCore strings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Geoffrey Garen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-25 23:31 PDT by Geoffrey Garen
Modified: 2011-04-26 11:31 PDT (History)
2 users (show)

See Also:

Attachments
Patch (17.64 KB, patch)
2011-04-25 23:44 PDT, Geoffrey Garen 		oliver: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2011-04-25 23:31:45 PDT 
Nixed special finalizer handling for WebCore strings
Comment 1 Geoffrey Garen 2011-04-25 23:44:42 PDT 
Created attachment 91071 [details]
Patch
Comment 2 Oliver Hunt 2011-04-26 08:11:49 PDT 
Comment on attachment 91071 [details]
Patch

I believe that it should be possible to do this with a WeakGCMap directly rather than switching to the less efficient hashmap<weak> model
Comment 3 Oliver Hunt 2011-04-26 08:40:18 PDT 
No I was wrong, although I'm not sure why I don't have it supported (i have most of what's need, just not an actual finalizer call).  It would be trivial to add a custom finalizer.
Comment 4 Oliver Hunt 2011-04-26 11:22:55 PDT 
Comment on attachment 91071 [details]
Patch

There's less thrashing in HashMap<Weak> than i thought,  so this is fine
Comment 5 Geoffrey Garen 2011-04-26 11:31:08 PDT 
Committed r84934: <http://trac.webkit.org/changeset/84934>