Bug 59417 - [GTK] Implement PluginInfoStore for WebKit2
Summary: [GTK] Implement PluginInfoStore for WebKit2
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-25 22:11 PDT by SangYong Park
Modified: 2011-06-10 00:26 PDT (History)
3 users (show)

See Also:

Attachments
Patch PluginInfoStore for gtk port (10.68 KB, patch)
2011-04-25 23:39 PDT, SangYong Park 		mrobinson: review-
Details | Formatted Diff | Diff
update qt build file (11.53 KB, patch)
2011-04-26 22:11 PDT, SangYong Park 		mrobinson: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description SangYong Park 2011-04-25 22:11:27 PDT 
Implement PluginInfoStore for WebKit2
Comment 1 SangYong Park 2011-04-25 23:39:08 PDT 
Created attachment 91068 [details]
Patch PluginInfoStore for gtk port
Comment 2 Martin Robinson 2011-04-26 21:16:46 PDT 
Comment on attachment 91068 [details]
Patch PluginInfoStore for gtk port

View in context: https://bugs.webkit.org/attachment.cgi?id=91068&action=review

Seems reasonable. Thanks!

> Source/WebKit2/ChangeLog:12
> +        (WebKit::Module::load): Return true if g_module_open() is successed.

is successed -> has succeeded
Comment 3 Martin Robinson 2011-04-26 21:17:31 PDT 
Comment on attachment 91068 [details]
Patch PluginInfoStore for gtk port

Just realized that this patch does not update the Qt build files! Flipping to r-.
Comment 4 SangYong Park 2011-04-26 22:11:15 PDT 
Created attachment 91230 [details]
update qt build file
Comment 5 Carlos Garcia Campos 2011-06-10 00:26:39 PDT 
This was already landed, closing.