Bug 59416 - Fix timestamp comparison in check-for-weak-vtables-and-externals
Summary: Fix timestamp comparison in check-for-weak-vtables-and-externals
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Mihai Parparita
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-25 21:39 PDT by Mihai Parparita
Modified: 2011-04-26 07:47 PDT (History)
4 users (show)

See Also:


Attachments
Patch (1.51 KB, patch)
2011-04-25 21:40 PDT, Mihai Parparita
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mihai Parparita 2011-04-25 21:39:19 PDT
Fix timestamp comparison in check-for-weak-vtables-and-externals
Comment 1 Mihai Parparita 2011-04-25 21:40:11 PDT
Created attachment 91052 [details]
Patch
Comment 2 Mihai Parparita 2011-04-25 21:41:55 PDT
Seems to shave a couple of seconds off a no-op build on my 12 core Mac Pro (currently at 21 seconds).
Comment 3 Eric Seidel (no email) 2011-04-25 22:46:10 PDT
Comment on attachment 91052 [details]
Patch

Yay!  What about the exit-time-destructors you were mentioning today?
Comment 4 Mihai Parparita 2011-04-25 22:57:49 PDT
(In reply to comment #3)
> (From update of attachment 91052 [details])
> Yay!  What about the exit-time-destructors you were mentioning today?

I think I got that mixed up with this script; it seems to behave as expected.
Comment 5 WebKit Commit Bot 2011-04-26 00:23:58 PDT
Comment on attachment 91052 [details]
Patch

Rejecting attachment 91052 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-3', 'apply-..." exit_code: 1

Last 500 characters of output:
  return self.open(self.click(*args, **kwds))
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_mechanize.py", line 203, in open
    return self._mech_open(url, data, timeout=timeout)
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_mechanize.py", line 255, in _mech_open
    raise response
webkitpy.thirdparty.autoinstalled.mechanize._response.httperror_seek_wrapper: HTTP Error 500: Internal Server Error

Full output: http://queues.webkit.org/results/8510508
Comment 6 WebKit Commit Bot 2011-04-26 07:47:26 PDT
Comment on attachment 91052 [details]
Patch

Clearing flags on attachment: 91052

Committed r84912: <http://trac.webkit.org/changeset/84912>
Comment 7 WebKit Commit Bot 2011-04-26 07:47:31 PDT
All reviewed patches have been landed.  Closing bug.