Bug 59407 - Fix MIPS build due to the split of "Condition" enum
Summary: Fix MIPS build due to the split of "Condition" enum
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-25 17:28 PDT by Chao-ying Fu
Modified: 2011-05-01 13:26 PDT (History)
3 users (show)

See Also:

Attachments
Fix branch32 and compare32 (5.13 KB, patch)
2011-04-25 17:40 PDT, Chao-ying Fu 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chao-ying Fu 2011-04-25 17:28:18 PDT 
I need to fix MacroAssemblerMIPS.h to remove some incorrect code, due to the split of "Condition" enum.  Will submit the patch soon.  Thanks a lot!

Regards,
Chao-ying
Comment 1 Chao-ying Fu 2011-04-25 17:40:07 PDT 
Created attachment 91031 [details]
Fix branch32 and compare32

This patch fixes branch32 and compare32 to remove incorrect ResultCondition that appears in the comparison.
This patch also fixes JSC::MIPSAssembler::debugOffset to use m_buffer.debugOffset().
JavaScriptCore tests are ok.
Thanks!
Comment 2 Eric Seidel (no email) 2011-05-01 12:32:43 PDT 
Comment on attachment 91031 [details]
Fix branch32 and compare32

OK.
Comment 3 WebKit Commit Bot 2011-05-01 13:26:52 PDT 
Comment on attachment 91031 [details]
Fix branch32 and compare32

Clearing flags on attachment: 91031

Committed r85429: <http://trac.webkit.org/changeset/85429>
Comment 4 WebKit Commit Bot 2011-05-01 13:26:57 PDT 
All reviewed patches have been landed.  Closing bug.