Bug 59399 - [GTK] Unskip accessibility/aria-combobox.html
Summary: [GTK] Unskip accessibility/aria-combobox.html
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Mario Sanchez Prada
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-25 16:46 PDT by Mario Sanchez Prada
Modified: 2011-04-26 16:20 PDT (History)
2 users (show)

See Also:


Attachments
Patch (4.84 KB, patch)
2011-04-25 16:51 PDT, Mario Sanchez Prada
no flags Details | Formatted Diff | Diff
Patch (6.38 KB, patch)
2011-04-25 16:54 PDT, Mario Sanchez Prada
no flags Details | Formatted Diff | Diff
Patch (6.96 KB, patch)
2011-04-25 16:57 PDT, Mario Sanchez Prada
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mario Sanchez Prada 2011-04-25 16:46:38 PDT
Two things would be needed here to unskip this test:

  * Implement isExpanded in GTK's DRT

  * Modify the layout test so it just prints out rolenames and leave the responsibility of checking whether they're correct to the, platform-dependent, expected files. This would imply updating the mac expected file, as it's the only platform providing one.
Comment 1 Mario Sanchez Prada 2011-04-25 16:51:39 PDT
Created attachment 91020 [details]
Patch
Comment 2 Mario Sanchez Prada 2011-04-25 16:54:08 PDT
Created attachment 91022 [details]
Patch

Sorry, stupid mistake in the ChangeLog in previous patch
Comment 3 Mario Sanchez Prada 2011-04-25 16:57:23 PDT
Created attachment 91025 [details]
Patch

Argh! God dammed jet lag!

(read as: "this is finally the good one")
Comment 4 Eric Seidel (no email) 2011-04-26 15:16:56 PDT
Comment on attachment 91025 [details]
Patch

OK.  Seems odd. that we would have these different expectations for gtk, but I Think I understand why.
Comment 5 chris fleizach 2011-04-26 15:31:47 PDT
Comment on attachment 91025 [details]
Patch

my only comment is that we prefix the role so that looking at a failed test it will be a little clearer
ie)
debug("Role: " + combobox.role);
Comment 6 Mario Sanchez Prada 2011-04-26 16:13:42 PDT
(In reply to comment #5)
> (From update of attachment 91025 [details])
> my only comment is that we prefix the role so that looking at a failed test it will be a little clearer
> ie)
> debug("Role: " + combobox.role);

I agree with this. I'll add that prefix (and update expectations) right before committing then.

Thanks
Comment 7 Mario Sanchez Prada 2011-04-26 16:20:49 PDT
Committed r84975: <http://trac.webkit.org/changeset/84975>