Bug 59399 – [GTK] Unskip accessibility/aria-combobox.html

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Mario Sanchez Prada]

Two things would be needed here to unskip this test:

  * Implement isExpanded in GTK's DRT

  * Modify the layout test so it just prints out rolenames and leave the responsibility of checking whether they're correct to the, platform-dependent, expected files. This would imply updating the mac expected file, as it's the only platform providing one.

[Mario Sanchez Prada]

Created attachment 91020 [details]
Patch

[Mario Sanchez Prada]

Created attachment 91022 [details]
Patch

Sorry, stupid mistake in the ChangeLog in previous patch

[Mario Sanchez Prada]

Created attachment 91025 [details]
Patch

Argh! God dammed jet lag!

(read as: "this is finally the good one")

[Eric Seidel (no email)]

Comment on attachment 91025 [details]
Patch

OK.  Seems odd. that we would have these different expectations for gtk, but I Think I understand why.

[chris fleizach]

Comment on attachment 91025 [details]
Patch

my only comment is that we prefix the role so that looking at a failed test it will be a little clearer
ie)
debug("Role: " + combobox.role);

[Mario Sanchez Prada]

(In reply to comment #5)
> (From update of attachment 91025 [details])
> my only comment is that we prefix the role so that looking at a failed test it will be a little clearer
> ie)
> debug("Role: " + combobox.role);

I agree with this. I'll add that prefix (and update expectations) right before committing then.

Thanks

[Mario Sanchez Prada]

Committed r84975: <http://trac.webkit.org/changeset/84975>