Bug 59389 - Make a couple of animation tests into text tests
Summary: Make a couple of animation tests into text tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-25 16:25 PDT by Simon Fraser (smfr)
Modified: 2011-04-25 21:03 PDT (History)
5 users (show)

See Also:


Attachments
Patch (51.37 KB, patch)
2011-04-25 16:26 PDT, Simon Fraser (smfr)
dbates: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2011-04-25 16:25:24 PDT
Make a couple of animation tests into text tests
Comment 1 Simon Fraser (smfr) 2011-04-25 16:26:38 PDT
Created attachment 91001 [details]
Patch
Comment 2 Daniel Bates 2011-04-25 16:31:35 PDT
Comment on attachment 91001 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=91001&action=review

> LayoutTests/animations/animation-drt-api-multiple-keyframes.html:5
> +  <style type="text/css">

Nit: This can be shortened to <style>.

> LayoutTests/animations/animation-drt-api-multiple-keyframes.html:25
> +   <script src="resources/animation-test-helpers.js" type="text/javascript"></script>
> +   <script type="text/javascript">

Nit: The type attribute is unnecessary.
Comment 3 Daniel Bates 2011-04-25 16:32:28 PDT
You're missing the expected results. Also, we could use the fast/js/resources scripts instead of doing this output by hand.
Comment 4 Simon Fraser (smfr) 2011-04-25 20:19:14 PDT
https://trac.webkit.org/changeset/84873
Comment 5 WebKit Review Bot 2011-04-25 21:03:56 PDT
http://trac.webkit.org/changeset/84873 might have broken SnowLeopard Intel Release (Tests)
The following tests are not passing:
compositing/animation/computed-style-during-delay.html
compositing/reflections/animation-inside-reflection.html
compositing/reflections/nested-reflection-animated.html
compositing/reflections/nested-reflection-transition.html
compositing/transitions/scale-transition-no-start.html
compositing/transitions/singular-scale-transition.html