Bug 59382 - WebCore/css/CSS* files should play nice with strict OwnPtrs
Summary: WebCore/css/CSS* files should play nice with strict OwnPtrs
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Adrienne Walker
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-25 16:15 PDT by Adrienne Walker
Modified: 2011-04-25 16:41 PDT (History)
4 users (show)

See Also:


Attachments
Patch (4.64 KB, patch)
2011-04-25 16:16 PDT, Adrienne Walker
levin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adrienne Walker 2011-04-25 16:15:31 PDT
WebCore/css/CSS* files should play nice with strict OwnPtrs
Comment 1 Adrienne Walker 2011-04-25 16:16:31 PDT
Created attachment 90988 [details]
Patch
Comment 2 David Levin 2011-04-25 16:20:04 PDT
Comment on attachment 90988 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=90988&action=review

two nits to fix.

> Source/WebCore/ChangeLog:8
> +        No new tests. (OOPS!)

Fix this :)

> Source/WebCore/css/CSSFontFaceSource.cpp:167
>                                                                                     fontDescription.textOrientation(), fontDescription.widthVariant(), fontDescription.renderingMode()), true, false));

This should be indented further.
Comment 3 Adrienne Walker 2011-04-25 16:37:01 PDT
Committed r84836: <http://trac.webkit.org/changeset/84836>
Comment 4 WebKit Review Bot 2011-04-25 16:41:44 PDT
http://trac.webkit.org/changeset/84836 might have broken Chromium Linux Release