Bug 59371 - Convert fast/events/focusingUnloadedFrame.html to dumpAsText
Summary: Convert fast/events/focusingUnloadedFrame.html to dumpAsText
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Mihai Parparita
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-25 16:04 PDT by Mihai Parparita
Modified: 2011-04-25 19:26 PDT (History)
3 users (show)

See Also:


Attachments
Patch (72.28 KB, patch)
2011-04-25 16:05 PDT, Mihai Parparita
no flags Details | Formatted Diff | Diff
Patch for landing (72.32 KB, patch)
2011-04-25 16:27 PDT, Mihai Parparita
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mihai Parparita 2011-04-25 16:04:22 PDT
Convert fast/events/focusingUnloadedFrame.html to dumpAsText
Comment 1 Mihai Parparita 2011-04-25 16:05:08 PDT
Created attachment 90977 [details]
Patch
Comment 2 Tony Chang 2011-04-25 16:18:53 PDT
Comment on attachment 90977 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=90977&action=review

> LayoutTests/fast/events/focusingUnloadedFrame.html:22
> +    setTimeout(step2, 100);

Nit: I wonder if we can lower this timeout to 0.
Comment 3 Mihai Parparita 2011-04-25 16:26:46 PDT
(In reply to comment #2)
> Nit: I wonder if we can lower this timeout to 0.

Seems to work even without the timeout. Will upload a new patch.
Comment 4 Mihai Parparita 2011-04-25 16:27:47 PDT
Created attachment 91002 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2011-04-25 19:26:20 PDT
Comment on attachment 91002 [details]
Patch for landing

Clearing flags on attachment: 91002

Committed r84865: <http://trac.webkit.org/changeset/84865>
Comment 6 WebKit Commit Bot 2011-04-25 19:26:23 PDT
All reviewed patches have been landed.  Closing bug.