WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED WONTFIX
5935
WebKit should consider using KDOM's RenderStyle macros for render_style.h cleanup
https://bugs.webkit.org/show_bug.cgi?id=5935
Summary
WebKit should consider using KDOM's RenderStyle macros for render_style.h cle...
Eric Seidel (no email)
Reported
2005-12-04 22:00:37 PST
WebKit should consider using KDOM's RenderStyle macros for render_style.h cleanup Instead of 3 lines per definition, a single macro line, like this: RS_DEFINE_ATTRIBUTE_DATAREF_WITH_INITIAL(int, visual, textDecoration, TextDecoration, TDNONE); The attached script and patch gets us most of the way there.
Attachments
render_style.h cleanup necessary before script will work
(7.14 KB, patch)
2005-12-04 22:02 PST
,
Eric Seidel (no email)
no flags
Details
Formatted Diff
Diff
script for condensing renderstyle accessors into macros
(7.74 KB, text/x-perl-script)
2005-12-04 22:03 PST
,
Eric Seidel (no email)
no flags
Details
View All
Add attachment
proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1
2005-12-04 22:02:30 PST
Created
attachment 4951
[details]
render_style.h cleanup necessary before script will work
Eric Seidel (no email)
Comment 2
2005-12-04 22:03:18 PST
Created
attachment 4952
[details]
script for condensing renderstyle accessors into macros
David Kilzer (:ddkilzer)
Comment 3
2008-02-22 17:04:18 PST
I think this may be closed as RESOLVED/WONTFIX. I believe the RS macros are gone from RenderStyle.h. Did you really write that Perl script, Eric? :)
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug