Bug 59349 - Enforce strict mode of OwnPtr
Summary: Enforce strict mode of OwnPtr
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P3 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-25 14:55 PDT by Benjamin Poulain
Modified: 2011-04-30 22:48 PDT (History)
6 users (show)

See Also:

Attachments
1) fix JSC (5.43 KB, patch)
2011-04-25 15:00 PDT, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
2) patch for WebCore (4.03 KB, patch)
2011-04-26 18:26 PDT, Benjamin Poulain 		jamesr: review-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2011-04-25 14:55:04 PDT 
For the sprint.
Refactor the code to get rid of implicit conversion and get rid of LOOSE_OWN_PTR.
Comment 1 Benjamin Poulain 2011-04-25 15:00:35 PDT 
Created attachment 90951 [details]
1) fix JSC
Comment 2 Benjamin Poulain 2011-04-25 15:25:36 PDT 
Comment on attachment 90951 [details]
1) fix JSC

Clearing the flags as the hackthon patches already conflict with this.
Comment 3 Benjamin Poulain 2011-04-26 18:26:55 PDT 
Created attachment 91202 [details]
2) patch for WebCore

Fix the remaining dependencies after the sprint. With this, the Mac port build with the strict mode.
Comment 4 Eric Seidel (no email) 2011-04-26 18:35:14 PDT 
I think the shadow part of the patch may be wrong.

Also kbr brought up some concerns about OwnPtr(OwnPtr&)... so I think others more involved in the effort should review this.  I'm tempted to r- this based on my believe that the shadow stuff is wrong (jamesr posted a related patch).
Comment 5 James Robinson 2011-04-26 18:46:08 PDT 
Comment on attachment 91202 [details]
2) patch for WebCore

This won't apply cleanly to ToT (I've fixed many of these issues).  Please update and repost if there are any other changes.
Comment 6 Benjamin Poulain 2011-04-30 22:48:48 PDT 
I can close this...the problem is mostly addressed upstream already.