Bug 59339 - WebCore build on Windows should include windows.h in its precompiled header to speed builds
Summary: WebCore build on Windows should include windows.h in its precompiled header t...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Steve Falkenburg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-25 13:39 PDT by Steve Falkenburg
Modified: 2011-04-25 13:51 PDT (History)
1 user (show)

See Also:

Attachments
Patch (1.38 KB, patch)
2011-04-25 13:45 PDT, Steve Falkenburg 		bweinstein: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Falkenburg 2011-04-25 13:39:23 PDT 
WebCore build on Windows should include windows.h in its precompiled header to speed builds
Comment 1 Steve Falkenburg 2011-04-25 13:45:55 PDT 
Created attachment 90938 [details]
Patch
Comment 2 WebKit Review Bot 2011-04-25 13:47:36 PDT 
Attachment 90938 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/WebCorePrefix.h:135:  "windows.h" already included at Source/WebCore/WebCorePrefix.h:120  [build/include] [4]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Steve Falkenburg 2011-04-25 13:51:38 PDT 
Committed r84797: <http://trac.webkit.org/changeset/84797>