Bug 59324 – [Windows and Leopard Tests] media/invalid-media-url-crash.html failing since r84762

• Status: RESOLVED
• Resolution: FIXED
• Component: Page Loading

[Jessie Berlin]

http://trac.webkit.org/changeset/84762

http://build.webkit.org/results/Windows%207%20Release%20(Tests)/r84760%20(12065)/results.html
http://build.webkit.org/results/Windows%207%20Release%20(Tests)/r84762%20(12066)/results.html

Interestingly, the WK1 bots are failing in a different way than the WK2 bots:

WK1:
http://build.webkit.org/results/Windows%207%20Release%20(Tests)/r84775%20(12075)/media/invalid-media-url-crash-pretty-diff.html
http://build.webkit.org/results/Windows%20XP%20Debug%20(Tests)/r84775%20(28015)/media/invalid-media-url-crash-pretty-diff.html

WK2:
http://build.webkit.org/results/Windows%207%20Release%20(WebKit2%20Tests)/r84776%20(5961)/media/invalid-media-url-crash-pretty-diff.html

[Jessie Berlin]

Added the test to the Windows skipped list in http://trac.webkit.org/changeset/84942

[Jessie Berlin]

This is also timing out on Leopard as of r84762 and is already on the mac-snowleopard skipped list. I am starting to wonder if the right thing to do is disable this test.

[Alexey Proskuryakov]

This test needs to be updated now that we treat http:aa\0%aa#aa as valid URL. But I'm not sure what URLs will stay reliably invalid.

[Alexey Proskuryakov]

I'm wondering how many other tests used this technique, and no longer test what they were supposed to.

[Jessie Berlin]

Maciej is going to try to first fix the test replacing the invalid URL with !:, which should really be invalid, and then going to try to find out why the check for invalid URLs was added in the code.

[Maciej Stachowiak]

Created attachment 91166 [details]
Patch

[Maciej Stachowiak]

Committed r84959: <http://trac.webkit.org/changeset/84959>