Bug 59323 - Web Inspector: worker messages should be routed to corresponding worker front-end
Summary: Web Inspector: worker messages should be routed to corresponding worker front...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Yury Semikhatsky
URL:
Keywords:
Depends on:
Blocks: 58541
  Show dependency tree / graph
 
Reported: 2011-04-25 08:40 PDT by Yury Semikhatsky
Modified: 2011-04-25 09:48 PDT (History)
11 users (show)

See Also:

Attachments
Patch (7.89 KB, patch)
2011-04-25 08:48 PDT, Yury Semikhatsky 		pfeldman: review+
Details | Formatted Diff | Diff
Patch for landing (7.98 KB, patch)
2011-04-25 09:27 PDT, Yury Semikhatsky 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yury Semikhatsky 2011-04-25 08:40:58 PDT 
Since we're going to have one front-end per inspected worker context, there should be a transport that would route worker messages to corresponding front-end.
Comment 1 Yury Semikhatsky 2011-04-25 08:48:54 PDT 
Created attachment 90919 [details]
Patch
Comment 2 Early Warning System Bot 2011-04-25 08:58:10 PDT 
Attachment 90919 [details] did not build on qt:
Build output: http://queues.webkit.org/results/8504707
Comment 3 Pavel Feldman 2011-04-25 09:07:38 PDT 
Comment on attachment 90919 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=90919&action=review

> Source/WebCore/inspector/front-end/WorkerManager.js:82
> +        workerId = parseInt(workerId, 10);

parseInt(workerId)

> Source/WebCore/inspector/front-end/WorkerManager.js:96
> +        this.workerIdToWindow_[workerId] = window.open(url);

this._workerIdToWindow
Comment 4 Yury Semikhatsky 2011-04-25 09:27:30 PDT 
Created attachment 90920 [details]
Patch for landing
Comment 5 Yury Semikhatsky 2011-04-25 09:48:17 PDT 
Committed r84780: <http://trac.webkit.org/changeset/84780>