Bug 59321 - Web Inspector: move Frame and Resource Tree management into the Page agent.
Summary: Web Inspector: move Frame and Resource Tree management into the Page agent.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-25 06:50 PDT by Pavel Feldman
Modified: 2011-04-25 07:14 PDT (History)
13 users (show)

See Also:


Attachments
Patch (73.10 KB, patch)
2011-04-25 06:52 PDT, Pavel Feldman
yurys: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2011-04-25 06:50:44 PDT
Network agent should only handle network-related activities. Frame structure should be managed by the Page agent instead.
Comment 1 Pavel Feldman 2011-04-25 06:52:56 PDT
Created attachment 90916 [details]
Patch
Comment 2 WebKit Review Bot 2011-04-25 07:03:16 PDT
Attachment 90916 [details] did not build on mac:
Build output: http://queues.webkit.org/results/8508257
Comment 3 Yury Semikhatsky 2011-04-25 07:08:53 PDT
Comment on attachment 90916 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=90916&action=review

> Source/WebCore/inspector/Inspector.json:67
> +                "description": "Resource type as it was perceived by the rendering enging."

enging -> engine.
Comment 4 WebKit Review Bot 2011-04-25 07:09:30 PDT
Attachment 90916 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/8507289
Comment 5 Pavel Feldman 2011-04-25 07:12:45 PDT
Committed r84774: <http://trac.webkit.org/changeset/84774>
Comment 6 Build Bot 2011-04-25 07:14:47 PDT
Attachment 90916 [details] did not build on win:
Build output: http://queues.webkit.org/results/8508261