RESOLVED FIXED 59318
[GTK] Initial tooltips implementation for WebKit2 
https://bugs.webkit.org/show_bug.cgi?id=59318
Summary [GTK] Initial tooltips implementation for WebKit2
Carlos Garcia Campos
Reported 2011-04-25 02:59:50 PDT
Initial tooltips implementation for WebKit2
Attachments
Patch (5.37 KB, patch)
2011-04-25 03:07 PDT, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Patch updated to current git master (5.11 KB, patch)
2011-05-30 04:17 PDT, Carlos Garcia Campos 		mrobinson: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2011-04-25 03:07:02 PDT
Created attachment 90911 [details] Patch It can be tested with both MiniBrowser and GtkLauncher (you need patch attached to bug #57820).
Martin Robinson
Comment 2 2011-04-26 16:53:14 PDT
Comment on attachment 90911 [details] Patch Going to remove the review flag here until we can resolve API discussions.
Carlos Garcia Campos
Comment 3 2011-05-30 04:17:02 PDT
Created attachment 95334 [details] Patch updated to current git master
Martin Robinson
Comment 4 2011-05-30 07:34:37 PDT
Comment on attachment 95334 [details] Patch updated to current git master View in context: https://bugs.webkit.org/attachment.cgi?id=95334&action=review > Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:295 > + if (keyboardMode) { > + notImplemented(); > + return FALSE; > + } This is for tooltips triggered by keyboard events, right? Is there a bug for this? If so it's probably best to leave the bug link in a comment. > Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:361 > + if (tooltip && *tooltip != '\0') { I think it's clearer to use tooltip[0] here.
Carlos Garcia Campos
Comment 5 2011-05-30 09:18:13 PDT
Committed r87689: <http://trac.webkit.org/changeset/87689>
Note You need to log in before you can comment on or make changes to this bug.