Bug 59318 - [GTK] Initial tooltips implementation for WebKit2
Summary: [GTK] Initial tooltips implementation for WebKit2
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
Keywords: Gtk
Depends on: 57944
  Show dependency treegraph
Reported: 2011-04-25 02:59 PDT by Carlos Garcia Campos
Modified: 2011-05-30 09:18 PDT (History)
3 users (show)

See Also:

Patch (5.37 KB, patch)
2011-04-25 03:07 PDT, Carlos Garcia Campos
no flags Details | Formatted Diff | Diff
Patch updated to current git master (5.11 KB, patch)
2011-05-30 04:17 PDT, Carlos Garcia Campos
mrobinson: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2011-04-25 02:59:50 PDT
Initial tooltips implementation for WebKit2
Comment 1 Carlos Garcia Campos 2011-04-25 03:07:02 PDT
Created attachment 90911 [details]

It can be tested with both MiniBrowser and GtkLauncher (you need patch attached to bug #57820).
Comment 2 Martin Robinson 2011-04-26 16:53:14 PDT
Comment on attachment 90911 [details]

Going to remove the review flag here until we can resolve API discussions.
Comment 3 Carlos Garcia Campos 2011-05-30 04:17:02 PDT
Created attachment 95334 [details]
Patch updated to current git master
Comment 4 Martin Robinson 2011-05-30 07:34:37 PDT
Comment on attachment 95334 [details]
Patch updated to current git master

View in context: https://bugs.webkit.org/attachment.cgi?id=95334&action=review

> Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:295
> +    if (keyboardMode) {
> +        notImplemented();
> +        return FALSE;
> +    }

This is for tooltips triggered by keyboard events, right? Is there a bug for this? If so it's probably best to leave the bug link in a comment.

> Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:361
> +    if (tooltip && *tooltip != '\0') {

I think it's clearer to use tooltip[0] here.
Comment 5 Carlos Garcia Campos 2011-05-30 09:18:13 PDT
Committed r87689: <http://trac.webkit.org/changeset/87689>