Bug 59315 - REGRESSION (WK2): Holding down Option while dragging scrollbar thumb has no effect (should make scroll distance equal mouse translation)
Summary: REGRESSION (WK2): Holding down Option while dragging scrollbar thumb has no e...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac All
: P1 Normal
Assignee: mitz
URL:
Keywords: InRadar, Regression
Depends on:
Blocks:
 
Reported: 2011-04-24 23:57 PDT by mitz
Modified: 2011-04-25 00:29 PDT (History)
0 users

See Also:

Attachments
Patch (7.47 KB, patch)
2011-04-25 00:04 PDT, mitz 		mjs: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2011-04-24 23:57:54 PDT 
REGRESSION (WK2): Holding down Option while dragging scrollbar thumb has no effect (should make scroll distance equal mouse translation)
Comment 1 mitz 2011-04-24 23:59:15 PDT 
<rdar://problem/9113516>
Comment 2 mitz 2011-04-25 00:04:51 PDT 
Created attachment 90905 [details]
Patch
Comment 3 Maciej Stachowiak 2011-04-25 00:23:27 PDT 
Comment on attachment 90905 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=90905&action=review

r=me but consider the naming.

> Source/WebCore/platform/Scrollbar.cpp:259
> +void Scrollbar::moveThumb(int pos, bool draggingDocument)

draggingDocument doesn't seem like a very clear name for what the different behavior is. Is there a way to name this more clearly?

I would suggest an enum instead of a bool here, but the usage seems clear at the one call site, so I won't.
Comment 4 mitz 2011-04-25 00:26:16 PDT 
Thanks for the review! I couldn’t think of a better and reasonably concise name, and I don’t think an enum is needed, given that the calls site doesn’t pass a boolean literal.
Comment 5 mitz 2011-04-25 00:29:12 PDT 
Fixed in r84767. <http://trac.webkit.org/changeset/84767>