REGRESSION (WK2): Holding down Option while dragging scrollbar thumb has no effect (should make scroll distance equal mouse translation)
Created attachment 90905 [details]
Comment on attachment 90905 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=90905&action=review
r=me but consider the naming.
> +void Scrollbar::moveThumb(int pos, bool draggingDocument)
draggingDocument doesn't seem like a very clear name for what the different behavior is. Is there a way to name this more clearly?
I would suggest an enum instead of a bool here, but the usage seems clear at the one call site, so I won't.
Thanks for the review! I couldn’t think of a better and reasonably concise name, and I don’t think an enum is needed, given that the calls site doesn’t pass a boolean literal.
Fixed in r84767. <http://trac.webkit.org/changeset/84767>