style-src should block @style
Created attachment 90870 [details] Patch
Attachment 90870 [details] did not pass chromium-ews: Output: http://queues.webkit.org/results/8497902
Attachment 90870 [details] did not build on qt: Build output: http://queues.webkit.org/results/8498897
Attachment 90870 [details] did not build on chromium: Build output: http://queues.webkit.org/results/8494985
Attachment 90870 [details] did not build on mac: Build output: http://queues.webkit.org/results/8495954
Attachment 90870 [details] did not build on win: Build output: http://queues.webkit.org/results/8495964
Attachment 90870 [details] did not build on gtk: Build output: http://queues.webkit.org/results/8497916
Comment on attachment 90870 [details] Patch No r+ for you, build-breaker! :p
Comment on attachment 90870 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=90870&action=review > Source/WebCore/dom/StyledElement.cpp:244 > + else if (document()->contentSecurityPolicy()->allowInlineStyle()) Should it early return instead? Should it be going down the destoryInlineStleDecl case instead? Why should it be re-calcing after?
> No r+ for you, build-breaker! :p It's just dependent on earlier patches. I should have mentioned that. > (From update of attachment 90870 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=90870&action=review > > > Source/WebCore/dom/StyledElement.cpp:244 > > + else if (document()->contentSecurityPolicy()->allowInlineStyle()) > > Should it early return instead? Should it be going down the destoryInlineStleDecl case instead? Why should it be re-calcing after? This seemed like a less disruptive way of blocking the attribute. We could destroy the attribute if you like, but that could have some odd behavior if there was some way of dynamically changing the CSP policy (which there isn't really today).
Created attachment 91789 [details] Patch
Comment on attachment 91789 [details] Patch OK.
Attachment 91789 [details] did not build on qt: Build output: http://queues.webkit.org/results/8523353
Attachment 91789 [details] did not build on chromium: Build output: http://queues.webkit.org/results/8521520
Comment on attachment 91789 [details] Patch Rejecting attachment 91789 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-3', 'build'..." exit_code: 2 Last 500 characters of output: VERSION_MINOR 0320 setenv YACC /Developer/usr/bin/yacc /bin/sh -c /mnt/git/webkit-commit-queue/WebKitBuild/WebCore.build/Debug/WebCore.build/Script-5DF50887116F3077005202AB.sh ** BUILD FAILED ** The following build commands failed: WebCore: CompileC /mnt/git/webkit-commit-queue/WebKitBuild/WebCore.build/Debug/WebCore.build/Objects-normal/x86_64/StyledElement.o /mnt/git/webkit-commit-queue/Source/WebCore/dom/StyledElement.cpp normal x86_64 c++ com.apple.compilers.gcc.4_2 (1 failure) Full output: http://queues.webkit.org/results/8460022
Comment on attachment 91789 [details] Patch Clearing flags on attachment: 91789 Committed r85384: <http://trac.webkit.org/changeset/85384>
All reviewed patches have been landed. Closing bug.