Bug 59287 - DFG JIT - Handle temporaries as vars, allowing support for ?:
Summary: DFG JIT - Handle temporaries as vars, allowing support for ?:
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Gavin Barraclough
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-23 18:00 PDT by Gavin Barraclough
Modified: 2011-04-23 18:06 PDT (History)
1 user (show)

See Also:

Attachments
The patch (10.52 KB, patch)
2011-04-23 18:02 PDT, Gavin Barraclough 		oliver: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2011-04-23 18:00:03 PDT 
SetLocals to temporaries will only be generated if they are used within other blocks, due to the SSA based DCE.
Comment 1 Gavin Barraclough 2011-04-23 18:02:17 PDT 
Created attachment 90864 [details]
The patch
Comment 2 Oliver Hunt 2011-04-23 18:04:10 PDT 
Comment on attachment 90864 [details]
The patch

r=me
Comment 3 WebKit Review Bot 2011-04-23 18:04:48 PDT 
Attachment 90864 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1

Source/JavaScriptCore/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Gavin Barraclough 2011-04-23 18:06:36 PDT 
fixed in r84748