Bug 59284 - [V8] Nodes in shadow DOM should not be GCed while their hosts are alive
Summary: [V8] Nodes in shadow DOM should not be GCed while their hosts are alive
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 52962
  Show dependency treegraph
 
Reported: 2011-04-23 15:28 PDT by Dominic Cooney
Modified: 2011-04-23 18:31 PDT (History)
2 users (show)

See Also:


Attachments
Patch (5.87 KB, patch)
2011-04-23 15:53 PDT, Dominic Cooney
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dominic Cooney 2011-04-23 15:28:58 PDT
The lifetime of nodes in shadow DOM and their hosts should be linked, since event listeners and JavaScript properties set up on one should not disappear (via the wrapper being prematurely garbage collected) while the other is alive.
Comment 1 Dominic Cooney 2011-04-23 15:53:50 PDT
Created attachment 90863 [details]
Patch
Comment 2 Dimitri Glazkov (Google) 2011-04-23 16:35:12 PDT
Comment on attachment 90863 [details]
Patch

awesome!
Comment 3 Hajime Morrita 2011-04-23 18:31:29 PDT
Comment on attachment 90863 [details]
Patch

Clearing flags on attachment: 90863

Committed r84749: <http://trac.webkit.org/changeset/84749>
Comment 4 Hajime Morrita 2011-04-23 18:31:33 PDT
All reviewed patches have been landed.  Closing bug.