when try to run the tests with lighttd server, for some reason server could not start.
Then I get following exception:
NameError: global name 'google' is not defined
Actually, in start method of Lighttpd class,
> raise google.httpd_utils.HttpdNotStarted('Failed to start httpd.')
raises a name error because google is not defined. This does not change much, as an exception is raised anyway. But may be it's better to raise a relevant exception.
Created attachment 90857 [details]
Created attachment 90858 [details]
As HttpdNotStarted is not used anywhere else, it's also possible to remove it totally, and raise a simple Exception as in pache_http_server.py
Comment on attachment 90858 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=90858&action=review
Would be nice to put a bit more detail here that google.httpd_utils.HttpdNotStarted does not exist.
Created attachment 91247 [details]
Comment on attachment 91247 [details]
Clearing flags on attachment: 91247
Committed r85447: <http://trac.webkit.org/changeset/85447>
All reviewed patches have been landed. Closing bug.
Committed r85449: <http://trac.webkit.org/changeset/85449>