Bug 59280 - [Refactoring] NodeRenderParentDetector should be NodeRenderFactory
Summary: [Refactoring] NodeRenderParentDetector should be NodeRenderFactory
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Hajime Morrita
URL:
Keywords:
Depends on:
Blocks: 59157
  Show dependency tree / graph
 
Reported: 2011-04-23 12:39 PDT by Hajime Morrita
Modified: 2011-04-23 17:52 PDT (History)
1 user (show)

See Also:

Attachments
Patch (7.00 KB, patch)
2011-04-23 15:35 PDT, Hajime Morrita 		dglazkov: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hajime Morrita 2011-04-23 12:39:52 PDT 
NodeRenderParentDetector is now in Node.cpp but it should have its own cpp/h.
Comment 1 Hajime Morrita 2011-04-23 15:18:02 PDT 
The role of this class is not clear yet. So i postpone to make a separate file and
do a refactoring first.
Comment 2 Hajime Morrita 2011-04-23 15:35:32 PDT 
Created attachment 90861 [details]
Patch
Comment 3 Dimitri Glazkov (Google) 2011-04-23 16:38:54 PDT 
Comment on attachment 90861 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=90861&action=review

ok with nits.

> Source/WebCore/ChangeLog:5
> +        [Refactoring] NodeRenderParentDetector should have its own file

Need to change the title here too.

> Source/WebCore/dom/Node.cpp:1614
> +    return NodeRendererFactory(const_cast<Node*>(this)).parentNodeForRenderingAndStyle();

Should we just remove the const modifier on the calling method?
Comment 4 Hajime Morrita 2011-04-23 17:52:03 PDT 
Committed r84747: <http://trac.webkit.org/changeset/84747>