Bug 59253 - CommitQueue should remember the expected failures from patch to patch
Summary: CommitQueue should remember the expected failures from patch to patch
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-22 16:23 PDT by Adam Barth
Modified: 2011-04-22 16:35 PDT (History)
1 user (show)

See Also:

Attachments
Patch (4.90 KB, patch)
2011-04-22 16:24 PDT, Adam Barth 		eric: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2011-04-22 16:23:35 PDT 
CommitQueue should remember the expected failures from patch to patch
Comment 1 Adam Barth 2011-04-22 16:24:49 PDT 
Created attachment 90799 [details]
Patch
Comment 2 Eric Seidel (no email) 2011-04-22 16:27:18 PDT 
Comment on attachment 90799 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=90799&action=review

Otherwise looks fine.

> Tools/Scripts/webkitpy/tool/bot/patchanalysistask.py:69
> -        self._expected_failures = ExpectedFailures()
> +        self._expected_failures = delegate.expected_failures()

Looks like we should jus tpass them into the constructor instead.
Comment 3 Adam Barth 2011-04-22 16:35:49 PDT 
Committed r84704: <http://trac.webkit.org/changeset/84704>