WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
59253
CommitQueue should remember the expected failures from patch to patch
https://bugs.webkit.org/show_bug.cgi?id=59253
Summary
CommitQueue should remember the expected failures from patch to patch
Adam Barth
Reported
2011-04-22 16:23:35 PDT
CommitQueue should remember the expected failures from patch to patch
Attachments
Patch
(4.90 KB, patch)
2011-04-22 16:24 PDT
,
Adam Barth
eric
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Adam Barth
Comment 1
2011-04-22 16:24:49 PDT
Created
attachment 90799
[details]
Patch
Eric Seidel (no email)
Comment 2
2011-04-22 16:27:18 PDT
Comment on
attachment 90799
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=90799&action=review
Otherwise looks fine.
> Tools/Scripts/webkitpy/tool/bot/patchanalysistask.py:69 > - self._expected_failures = ExpectedFailures() > + self._expected_failures = delegate.expected_failures()
Looks like we should jus tpass them into the constructor instead.
Adam Barth
Comment 3
2011-04-22 16:35:49 PDT
Committed
r84704
: <
http://trac.webkit.org/changeset/84704
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug