Bug 59250 - Add missing default constructors for HashMap iterator specializations.
Summary: Add missing default constructors for HashMap iterator specializations.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-22 15:47 PDT by Vitaly Repeshko
Modified: 2011-04-27 18:31 PDT (History)
2 users (show)

See Also:


Attachments
patch (2.19 KB, patch)
2011-04-22 15:49 PDT, Vitaly Repeshko
no flags Details | Formatted Diff | Diff
patch (2.25 KB, patch)
2011-04-22 16:20 PDT, Vitaly Repeshko
abarth: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Vitaly Repeshko 2011-04-22 15:47:20 PDT
Add missing default constructors for HashMap iterator specializations.
Comment 1 Vitaly Repeshko 2011-04-22 15:49:28 PDT
Created attachment 90787 [details]
patch
Comment 2 Adam Barth 2011-04-22 16:12:40 PDT
Comment on attachment 90787 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=90787&action=review

> Source/JavaScriptCore/wtf/HashTable.h:129
> -            addIterator(0, this);
> +            addIterator(static_cast<const HashTableType*>(0), this);

Why is this needed?  More explanation in the ChangeLog would be helpful.
Comment 3 Vitaly Repeshko 2011-04-22 16:20:12 PDT
Created attachment 90798 [details]
patch

Added the explanation to ChangeLog.
Comment 4 Vitaly Repeshko 2011-04-22 17:59:55 PDT
	M	Source/JavaScriptCore/ChangeLog
	M	Source/JavaScriptCore/wtf/HashIterators.h
	M	Source/JavaScriptCore/wtf/HashTable.h
Committed r84718
Comment 5 Alexey Proskuryakov 2011-04-22 21:54:18 PDT
+        HashTableConstIteratorAdapter() {}

WebKit style is to have a space between such braces. Please file a bug against the style checker.
Comment 6 David Levin 2011-04-27 18:31:14 PDT
(In reply to comment #5)
> +        HashTableConstIteratorAdapter() {}
> 
> WebKit style is to have a space between such braces. Please file a bug against the style checker.

We really don't have this in the style guide but we commonly flag it. We probably should add it to the style guide.

Anyway, this was an easy change to do on my plane flight: https://bugs.webkit.org/show_bug.cgi?id=59665