Bug 59250 – Add missing default constructors for HashMap iterator specializations.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Vitaly Repeshko]

Add missing default constructors for HashMap iterator specializations.

[Vitaly Repeshko]

Created attachment 90787 [details]
patch

[Adam Barth]

Comment on attachment 90787 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=90787&action=review

> Source/JavaScriptCore/wtf/HashTable.h:129
> -            addIterator(0, this);
> +            addIterator(static_cast<const HashTableType*>(0), this);

Why is this needed?  More explanation in the ChangeLog would be helpful.

[Vitaly Repeshko]

Created attachment 90798 [details]
patch

Added the explanation to ChangeLog.

[Vitaly Repeshko]

	M	Source/JavaScriptCore/ChangeLog
	M	Source/JavaScriptCore/wtf/HashIterators.h
	M	Source/JavaScriptCore/wtf/HashTable.h
Committed r84718

[Alexey Proskuryakov]

+        HashTableConstIteratorAdapter() {}

WebKit style is to have a space between such braces. Please file a bug against the style checker.

[David Levin]

(In reply to comment #5)
> +        HashTableConstIteratorAdapter() {}
> 
> WebKit style is to have a space between such braces. Please file a bug against the style checker.

We really don't have this in the style guide but we commonly flag it. We probably should add it to the style guide.

Anyway, this was an easy change to do on my plane flight: https://bugs.webkit.org/show_bug.cgi?id=59665