RESOLVED FIXED59248
WebKit2: Implement JavaScript unresponsiveness timer/callbacks 
https://bugs.webkit.org/show_bug.cgi?id=59248
Summary WebKit2: Implement JavaScript unresponsiveness timer/callbacks
Sam Weinig
Reported 2011-04-22 15:28:16 PDT
WebKit2: Implement JavaScript unresponsiveness timer/callbacks
Attachments
Patch (10.38 KB, patch)
2011-04-22 15:34 PDT, Sam Weinig 		bweinstein: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2011-04-22 15:34:44 PDT
Created attachment 90783 [details] Patch
Early Warning System Bot
Comment 2 2011-04-22 16:18:46 PDT
Attachment 90783 [details] did not build on qt: Build output: http://queues.webkit.org/results/8495589
Brian Weinstein
Comment 3 2011-04-22 16:24:43 PDT
Comment on attachment 90783 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=90783&action=review > Source/WebKit2/UIProcess/WebPageProxy.cpp:1949 > + // Since runJavaScriptPrompt() can spin a nested run loop we need to turn off the responsiveness timer. Did you mean for this to be shouldInterruptJavaScript?
Jeff Miller
Comment 4 2011-04-22 16:25:29 PDT
Comment on attachment 90783 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=90783&action=review > Source/WebKit2/UIProcess/API/qt/qwkpage.cpp:503 > + 0 /* saveDataToFileInDownloadsFolder */ Missing a comma here, which is what probably broke the Qt build.
Sam Weinig
Comment 5 2011-04-22 16:29:07 PDT
Committed r84702: <http://trac.webkit.org/changeset/84702>
Note You need to log in before you can comment on or make changes to this bug.