Having a spinner, a UI decision, is nicely made optional in RenderTextControlSingleLine. Instead of defaulting certain input types to use a spinner, let the RenderTheme make the decision.
Created attachment 90776 [details] [PATCH] Let RenderTheme make the decisions Currently only TextFields check if a SpinButton should be added. However the RenderTheme decision could be used in other places in the future.
Created attachment 90777 [details] [PATCH] Let RenderTheme make the decisions Updated ChangeLog. (git add issue!)
Comment on attachment 90777 [details] [PATCH] Let RenderTheme make the decisions View in context: https://bugs.webkit.org/attachment.cgi?id=90777&action=review > Source/WebCore/rendering/RenderTheme.h:206 > + // Return true if the input element should have a spin button. > + virtual bool shouldHaveSpinButtonForInputElement(InputElement*) const; nit: The comment might be unnecessary. nit: "ForInputElement" in the function name is redundant. We may remove it.
> > Source/WebCore/rendering/RenderTheme.h:206 > > + // Return true if the input element should have a spin button. > > + virtual bool shouldHaveSpinButtonForInputElement(InputElement*) const; > > nit: The comment might be unnecessary. > nit: "ForInputElement" in the function name is redundant. We may remove it. Sounds good. Thanks!
Landed in <http://trac.webkit.org/changeset/84695>. Thanks!