Bug 59244 - Factor LayoutTestResultsReader out of CommitQueue
Summary: Factor LayoutTestResultsReader out of CommitQueue
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-22 15:09 PDT by Adam Barth
Modified: 2011-04-22 16:04 PDT (History)
3 users (show)

See Also:

Attachments
Patch (20.74 KB, patch)
2011-04-22 15:10 PDT, Adam Barth 		eric: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2011-04-22 15:09:54 PDT 
Factor LayoutTestResultsReader out of CommitQueue
Comment 1 Adam Barth 2011-04-22 15:10:49 PDT 
Created attachment 90774 [details]
Patch
Comment 2 Eric Seidel (no email) 2011-04-22 15:13:18 PDT 
Comment on attachment 90774 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=90774&action=review

> Tools/Scripts/webkitpy/tool/bot/layouttestresultsreader.py:39
> +        self._log_directory = log_directory

I would name this archive_directory or something.

> Tools/Scripts/webkitpy/tool/bot/layouttestresultsreader.py:55
> +        return LayoutTestResults.results_from_string(results_html)

Heads up: Ojan is about to break this call into two calls.  One for ORWT and one for NRWT.

> Tools/Scripts/webkitpy/tool/bot/layouttestresultsreader.py:64
> +            results.set_failure_limit_count(RunTests.NON_INTERACTIVE_FAILURE_LIMIT_COUNT)

Heads up: this is going to be wrong for NWRT.
Comment 3 Adam Barth 2011-04-22 15:17:34 PDT 
Committed r84689: <http://trac.webkit.org/changeset/84689>
Comment 4 WebKit Review Bot 2011-04-22 16:04:15 PDT 
http://trac.webkit.org/changeset/84689 might have broken SnowLeopard Intel Release (Build)