WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED WONTFIX
59243
Develop sufficient test coverage for editing inside input/textarea
https://bugs.webkit.org/show_bug.cgi?id=59243
Summary
Develop sufficient test coverage for editing inside input/textarea
Dimitri Glazkov (Google)
Reported
2011-04-22 15:01:22 PDT
In order to land the switch-over to the new shadow DOM, we must ensure that the areas of change are sufficiently covered by layout tests. To do this, we should study all places where the shadow DOM changes assumptions and make sure these changes don't break the behavior. A good start would be to look at all callsites of parentNode() in editing and ensure we have tests that travel them.
http://codesearch.google.com/codesearch?q=%22parentNode%28%29%22+file%3Aediting&exact_package=chromium&hl=en&vert=chromium
Attachments
WIP: Beginnings of the harness.
(3.45 KB, patch)
2011-05-01 21:12 PDT
,
Dimitri Glazkov (Google)
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Dimitri Glazkov (Google)
Comment 1
2011-05-01 21:12:27 PDT
Created
attachment 91876
[details]
WIP: Beginnings of the harness.
Dimitri Glazkov (Google)
Comment 2
2011-05-18 14:34:45 PDT
Quick update: We (rniwa, anniesullivan, myself) defined the test matrix and made first pass at culling, producing around 940K combinations, with an approximate run time of 3 hours. Clearly, this is not something we can afford to run in LayoutTests. Perhaps this needs to be done as a separate bot or something entirely different. In order to unblock shadow DOM conversion, we instead focused on something a bit smarter than effectively fuzz-testing. Specifically, we walked through editing code and identifying all areas where the shadow DOM changes would have affects.
Ryosuke Niwa
Comment 3
2011-06-03 21:15:04 PDT
This is no longer needed.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug