Bug 59224 - Don't rely on hasSpinButton to check if an input type can be stepped
Summary: Don't rely on hasSpinButton to check if an input type can be stepped
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-22 13:01 PDT by Joseph Pecoraro
Modified: 2011-04-22 16:19 PDT (History)
6 users (show)

See Also:

Attachments
[PATCH] Proposed Fix - Add isSteppable (7.10 KB, patch)
2011-04-22 13:10 PDT, Joseph Pecoraro 		tkent: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2011-04-22 13:01:06 PDT 
Add isSteppable. This almost removes the last usage of isRangeControl, but it
is used once later on in the function. We shouldn't assert that a steppable
control has a spinner, since a spinner is a UI detail and steppability is
functionality.
Comment 1 Joseph Pecoraro 2011-04-22 13:10:35 PDT 
Created attachment 90746 [details]
[PATCH] Proposed Fix - Add isSteppable
Comment 2 Kent Tamura 2011-04-22 13:35:34 PDT 
Comment on attachment 90746 [details]
[PATCH] Proposed Fix - Add isSteppable

ok
Comment 3 Joseph Pecoraro 2011-04-22 14:33:28 PDT 
Landed in <http://trac.webkit.org/changeset/84683>.
Comment 4 Joseph Pecoraro 2011-04-22 14:37:57 PDT 
Arg, I should also have removed the now unused HTMLInputElement::hasSpinButton.
I'll be working on a follow-up patch that will do that soon.
Comment 5 WebKit Review Bot 2011-04-22 16:19:01 PDT 
http://trac.webkit.org/changeset/84683 might have broken GTK Linux 64-bit Debug