Bug 59220 - Factor PatchAnalysis task out of CommitQueueTask
Summary: Factor PatchAnalysis task out of CommitQueueTask
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-22 12:15 PDT by Adam Barth
Modified: 2011-04-22 12:25 PDT (History)
1 user (show)

See Also:

Attachments
Patch (19.73 KB, patch)
2011-04-22 12:16 PDT, Adam Barth 		eric: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2011-04-22 12:15:45 PDT 
Factor PatchAnalysis task out of CommitQueueTask
Comment 1 Adam Barth 2011-04-22 12:16:55 PDT 
Created attachment 90739 [details]
Patch
Comment 2 Eric Seidel (no email) 2011-04-22 12:21:13 PDT 
Comment on attachment 90739 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=90739&action=review

OK.  Shouldn't the unit tests move too?

> Tools/Scripts/webkitpy/tool/bot/patchanalysistask.py:213
> +        assert(self._patch.id() == patch.id())  # CommitQueueTask is not currently re-useable.

CommitQueueTask?
Comment 3 Adam Barth 2011-04-22 12:25:39 PDT 
Committed r84658: <http://trac.webkit.org/changeset/84658>
Comment 4 Adam Barth 2011-04-22 12:25:54 PDT 
> OK.  Shouldn't the unit tests move too?

The unit tests are testing run(), which only exists on the child object.