RESOLVED FIXED 59220
Factor PatchAnalysis task out of CommitQueueTask 
https://bugs.webkit.org/show_bug.cgi?id=59220
Summary Factor PatchAnalysis task out of CommitQueueTask
Adam Barth
Reported 2011-04-22 12:15:45 PDT
Factor PatchAnalysis task out of CommitQueueTask
Attachments
Patch (19.73 KB, patch)
2011-04-22 12:16 PDT, Adam Barth 		eric: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2011-04-22 12:16:55 PDT
Created attachment 90739 [details] Patch
Eric Seidel (no email)
Comment 2 2011-04-22 12:21:13 PDT
Comment on attachment 90739 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=90739&action=review OK. Shouldn't the unit tests move too? > Tools/Scripts/webkitpy/tool/bot/patchanalysistask.py:213 > + assert(self._patch.id() == patch.id()) # CommitQueueTask is not currently re-useable. CommitQueueTask?
Adam Barth
Comment 3 2011-04-22 12:25:39 PDT
Committed r84658: <http://trac.webkit.org/changeset/84658>
Adam Barth
Comment 4 2011-04-22 12:25:54 PDT
> OK. Shouldn't the unit tests move too? The unit tests are testing run(), which only exists on the child object.
Note You need to log in before you can comment on or make changes to this bug.