Bug 59216 - Sheriffbot should be taught about contributors
Summary: Sheriffbot should be taught about contributors
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 59209
Blocks:
  Show dependency tree / graph
 
Reported: 2011-04-22 11:48 PDT by Eric Seidel (no email)
Modified: 2011-11-06 11:37 PST (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2011-04-22 11:48:21 PDT 
Sheriffbot should be taught about contributors

In bug 59209, support for contributors who are not committers was added.

We need to add new functions "contributor_by_email" and "contributor_by_name" to committers.py

and change this one callsite:
http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/checkout/changelog.py#L67

And then the sheriffbot will be able to notify contributors over IRC.

I suspect we'll want to audit all other uses of committer_by_email as well.
Comment 1 Eric Seidel (no email) 2011-11-06 11:37:45 PST 
I think it got changed already?
http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/checkout/changelog.py#L108